LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Eyal Reizer <eyalreizer@gmail.com>
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
	robh@kernel.org, sre@kernel.org, linux-kernel@vger.kernel.org,
	Eyal Reizer <eyalr@ti.com>
Subject: Re: [PATCH] net: wireless: ti: wlcore: sdio: allow pm to handle sdio power
Date: Wed, 25 Apr 2018 06:55:52 -0700	[thread overview]
Message-ID: <20180425135552.GX5671@atomide.com> (raw)
In-Reply-To: <1524663710-31927-1-git-send-email-eyalr@ti.com>

* Eyal Reizer <eyalreizer@gmail.com> [180425 13:43]:
> pm_runtime handles sdio power on and power off transitions.
> An old workaround for trying to control the power explicitly from the
> driver was in fact causing failures on suspend/resume as the mmc layer
> already power the module on resume.
> 
> In case of resume pm_runtime_get sync returns a positive device's usage
> count causing the driver to try an re-initialize an already initialized
> device. This was causing sdio bus failure on resume.
> 
> Remove this manual power on/off sequence as it is in-fact not needed.
> 
> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> Cc: stable@vger.kernel.org

Stable cc dropped, see Documentation/process/stable-kernel-rules.rst.

Looks good to me:

Acked-by: Tony Lindgren <tony@atomide.com>

  reply	other threads:[~2018-04-25 13:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 13:41 Eyal Reizer
2018-04-25 13:55 ` Tony Lindgren [this message]
2018-04-25 13:58 ` [PATCH] " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425135552.GX5671@atomide.com \
    --to=tony@atomide.com \
    --cc=eyalr@ti.com \
    --cc=eyalreizer@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --subject='Re: [PATCH] net: wireless: ti: wlcore: sdio: allow pm to handle sdio power' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).