From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754794AbeDYO7Z (ORCPT ); Wed, 25 Apr 2018 10:59:25 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45286 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754196AbeDYO7X (ORCPT ); Wed, 25 Apr 2018 10:59:23 -0400 Date: Wed, 25 Apr 2018 16:59:20 +0200 From: Jiri Olsa To: "Liang, Kan" Cc: acme@kernel.org, mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, ganapatrao.kulkarni@cavium.com, zhangshaokun@hisilicon.com, yao.jin@linux.intel.com, will.deacon@arm.com, ak@linux.intel.com, agustinv@codeaurora.org Subject: Re: [V2 PATCH] perf parse-events: Specially handle uncore event alias in small groups Message-ID: <20180425145920.GF3396@krava> References: <1524664218-134407-1-git-send-email-kan.liang@linux.intel.com> <20180425142337.GE3396@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 25, 2018 at 10:42:27AM -0400, Liang, Kan wrote: > > > On 4/25/2018 10:23 AM, Jiri Olsa wrote: > > On Wed, Apr 25, 2018 at 06:50:18AM -0700, kan.liang@linux.intel.com wrote: > > > From: Kan Liang > > > > > > Perf stat doesn't count the uncore event aliases from the same uncore > > > block in a group, for example: > > > > > > perf stat -e '{unc_m_cas_count.all,unc_m_clockticks}' -a -I 1000 > > > # time counts unit events > > > 1.000447342 unc_m_cas_count.all > > > 1.000447342 unc_m_clockticks > > > 2.000740654 unc_m_cas_count.all > > > 2.000740654 unc_m_clockticks > > > > > > The output is very misleading. It gives a wrong impression that the > > > uncore event doesn't work. > > > > > > An uncore block could be composed by several PMUs. An uncore event alias > > > is a joint name which means the same event runs on all PMUs of a block. > > > Perf doesn't support mixed events from different PMUs in the same group. > > > It is wrong to put uncore event aliases in a big group. > > > > > > The right way is to split the big group into multiple small groups which > > > only include the events from the same PMU. > > > Only uncore event aliases from the same uncore block should be specially > > > handled here. It doesn't make sense to mix the uncore events with other > > > uncore events from different blocks or even core events in a group. > > > > > > With the patch: > > > # time counts unit events > > > 1.001557653 140,833 unc_m_cas_count.all > > > 1.001557653 1,330,231,332 unc_m_clockticks > > > 2.002709483 85,007 unc_m_cas_count.all > > > 2.002709483 1,429,494,563 unc_m_clockticks > > > > hum, I still can see the original behaviour even with the patch: > > > > That's because the data_reads and clockticks are from different uncore > blocks. The data_reads is a IMC event. The clockticks is a CBOX event. > > The patch only supports the events from the same uncore blocks in group. I see, found another example from same uncore blocks and it seems to work: # perf stat -e '{cas_count_read,cas_count_write}' -a -I 1000 but I have it aborted on: # ./perf stat -e '{cas_count_read,cas_count_write,cas_count_read}' -a -I 1000 perf: util/evsel.c:1483: get_group_fd: Assertion `!(!leader->fd)' failed. Aborted (core dumped) jirka