LKML Archive on
help / color / mirror / Atom feed
From: Richard Cochran <>
To: Yangbo Lu <>
	Greg Kroah-Hartman <>,,
Subject: Re: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware timestamping
Date: Wed, 25 Apr 2018 19:33:08 -0700	[thread overview]
Message-ID: <20180426023308.aezdge7xlbqoe5at@localhost> (raw)
In-Reply-To: <>

On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:

> +/* PTP nominal frequency 1GHz */

Nit: Frequency is the inverse of the period.  It can be one or the
other, not both.

Why not call it simply DPAA2_PTP_CLK_PERIOD_NS?

You haven't implemented the ethtool_get_ts_info() method, but you need
to do so.  Show us how the user can related these MAC time stamps to
the PHC device in your other patch series.

devel mailing list

  parent reply	other threads:[~2018-04-26  2:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  9:17 Yangbo Lu
2018-04-25 10:03 ` Dan Carpenter
2018-04-26 10:17   ` Y.b. Lu
2018-04-26  2:33 ` Richard Cochran [this message]
2018-04-26 10:22   ` Y.b. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426023308.aezdge7xlbqoe5at@localhost \ \ \ \ \ \ \
    --subject='Re: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware timestamping' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).