LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: geert@linux-m68k.org, robh+dt@kernel.org, mark.rutland@arm.com,
	linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0
Date: Thu, 26 Apr 2018 08:11:30 +0200	[thread overview]
Message-ID: <20180426061124.hvgl3ijf6ulrdkmn@verge.net.au> (raw)
In-Reply-To: <1524654920-18749-3-git-send-email-jacopo+renesas@jmondi.org>

Thanks Jacopo,

I'm very pleased to see this series.

On Wed, Apr 25, 2018 at 01:15:20PM +0200, Jacopo Mondi wrote:
> Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740.

Given 'status = "disabled"' below I think you
are describing but not enabling CEU0. Also in the subject.

Should we also describe CEU1?

> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> index afd3bc5..05ec41e 100644
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -67,6 +67,16 @@
>  		power-domains = <&pd_d4>;
>  	};
>  
> +	ceu0: ceu@fe910000 {
> +		reg = <0xfe910000 0x100>;

Should the size of the range be 0x3000 ?
That would seem to match my reading of table 32.3
and also be consistent with r7s72100.dtsi.

> +		compatible = "renesas,r8a7740-ceu";
> +		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp1_clks R8A7740_CLK_CEU20>;
> +		clock-names = "ceu20";
> +		power-domains = <&pd_a4mp>;

My reading of table 1.7 is that the power domain should be A4R (&pd_a4r).

> +		status = "disabled";
> +	};
> +
>  	cmt1: timer@e6138000 {
>  		compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
>  		reg = <0xe6138000 0x170>;
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-04-26  6:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 11:15 [PATCH 0/2] renesas: ceu: Add R-Mobile A1 Jacopo Mondi
2018-04-25 11:15 ` [PATCH 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740 Jacopo Mondi
2018-04-25 11:15 ` [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0 Jacopo Mondi
2018-04-26  6:11   ` Simon Horman [this message]
2018-04-26  7:26     ` jacopo mondi
2018-04-26  8:53       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426061124.hvgl3ijf6ulrdkmn@verge.net.au \
    --to=horms@verge.net.au \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).