From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753307AbeDZGuP (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Apr 2018 02:50:15 -0400
Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:46430 "EHLO
        hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751528AbeDZGuM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Apr 2018 02:50:12 -0400
Date: Thu, 26 Apr 2018 09:50:10 +0300
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Todor Tomov <todor.tomov@linaro.org>
Cc: mchehab@kernel.org, hverkuil@xs4all.nl,
        laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] media: Add a driver for the ov7251 camera sensor
Message-ID: <20180426065010.a67iqsaicpgu7m5b@valkosipuli.retiisi.org.uk>
References: <1524673246-14175-1-git-send-email-todor.tomov@linaro.org>
 <1524673246-14175-3-git-send-email-todor.tomov@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1524673246-14175-3-git-send-email-todor.tomov@linaro.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Todor,

On Wed, Apr 25, 2018 at 07:20:46PM +0300, Todor Tomov wrote:
...
> +static int ov7251_write_reg(struct ov7251 *ov7251, u16 reg, u8 val)
> +{
> +	u8 regbuf[3];
> +	int ret;
> +
> +	regbuf[0] = reg >> 8;
> +	regbuf[1] = reg & 0xff;
> +	regbuf[2] = val;
> +
> +	ret = i2c_master_send(ov7251->i2c_client, regbuf, 3);
> +	if (ret < 0) {
> +		dev_err(ov7251->dev, "%s: write reg error %d: reg=%x, val=%x\n",
> +			__func__, ret, reg, val);
> +		return ret;
> +	}
> +
> +	return 0;

How about:

	return ov7251_write_seq_regs(ov7251, reg, &val, 1);

And put the function below ov2751_write_seq_regs().

> +}
> +
> +static int ov7251_write_seq_regs(struct ov7251 *ov7251, u16 reg, u8 *val,
> +				 u8 num)
> +{
> +	const u8 maxregbuf = 5;
> +	u8 regbuf[maxregbuf];
> +	u8 nregbuf = sizeof(reg) + num * sizeof(*val);
> +	int ret = 0;
> +
> +	if (nregbuf > maxregbuf)
> +		return -EINVAL;
> +
> +	regbuf[0] = reg >> 8;
> +	regbuf[1] = reg & 0xff;
> +
> +	memcpy(regbuf + 2, val, num);
> +
> +	ret = i2c_master_send(ov7251->i2c_client, regbuf, nregbuf);
> +	if (ret < 0) {
> +		dev_err(ov7251->dev, "%s: write seq regs error %d: first reg=%x\n",

This line is over 80... 

If you're happy with these, I can make the changes, too; they're trivial.

> +			__func__, ret, reg);
> +		return ret;
> +	}
> +
> +	return 0;
> +}

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi