LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Colin King <colin.king@canonical.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks object size
Date: Thu, 26 Apr 2018 09:02:42 -0400	[thread overview]
Message-ID: <20180426130242.GA10587@sophia> (raw)
In-Reply-To: <CACRpkdZ2zRJfcSWbi_zwvtMnu_eGqAi684Wh3qWfjMazJqNsUA@mail.gmail.com>

On Thu, Apr 26, 2018 at 11:06:05AM +0200, Linus Walleij wrote:
>On Thu, Apr 5, 2018 at 2:00 PM, Colin King <colin.king@canonical.com> wrote:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Don't populate the const read-only array 'ports' on the stack but instead
>> make it static. Makes the object code smaller by over 100 buytes:
>>
>> Before:
>>    text    data     bss     dec     hex filename
>>   10959    4952     832   16743    4167 drivers/gpio/gpio-104-dio-48e.o
>>
>> After:
>>    text    data     bss     dec     hex filename
>>   10790    5008     832   16630    40f6 drivers/gpio/gpio-104-dio-48e.o
>>
>> (gcc version 7.2.0 x86_64)
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
>Patch applied with William's ACK.
>
>Yours,
>Linus Walleij

Hi Linus,

A more recent version of this patch including similar changes to
gpio-gpio-mm.c and gpio-104-idi-48.c is located here:
https://lkml.org/lkml/2018/4/18/613

William Breathitt Gray

      reply	other threads:[~2018-04-26 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 12:00 Colin King
2018-04-05 12:19 ` William Breathitt Gray
2018-04-26  9:06 ` Linus Walleij
2018-04-26 13:02   ` William Breathitt Gray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426130242.GA10587@sophia \
    --to=vilhelm.gray@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] gpio: 104-dio-48e: make array '\''ports'\'' static, shrinks object size' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).