LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
	Vaishali Thakkar <vthakkar1994@gmail.com>,
	alexander.deucher@amd.com, linux-renesas-soc@vger.kernel.org,
	heiko@sntech.de, airlied@linux.ie, linus.walleij@linaro.org,
	stefan@agner.ch, hjc@rock-chips.com, kraxel@redhat.com,
	benjamin.gaignard@linaro.org, nouveau@lists.freedesktop.org,
	marex@denx.de, David1.Zhou@amd.com,
	linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com,
	linux-rockchip@lists.infradead.org, tomi.valkeinen@ti.com,
	linux@armlinux.org.uk, krzk@kernel.org, jonathanh@nvidia.com,
	z.liuxinliang@hisilicon.com, maxime.ripard@bootlin.com,
	kong.kongxinwei@hisilicon.com, kgene@kernel.org,
	bskeggs@redhat.com, linux-arm-msm@vger.kernel.org,
	ck.hu@mediatek.com, airlied@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-tegra@vger.kernel.org, puck.chen@hisilicon.com,
	intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org,
	brodkin@synopsys.com, dri-devel@lists.freedesktop.org,
	rodrigo.vivi@intel.com, matthias.bgg@gmail.com, wens@csie.org,
	vincent.abriou@st.com, linux-arm-kernel@lists.infradead.org,
	inki.dae@samsung.com, amd-gfx@lists.freedesktop.org,
	alison.wang@freescale.com, freedreno@lists.freedesktop.org,
	sw0312.kim@samsung.com, nicolas.ferre@microchip.com,
	philippe.cornu@st.com, linux-kernel@vger.kernel.org,
	yannick.fertre@st.com, kyungmin.park@samsung.com,
	noralf@tronnes.org, p.zabel@pengutronix.de,
	zourongrong@gmail.com, linux-mediatek@lists.infradead.org,
	shawnguo@kernel.org, christian.koenig@amd.com,
	l.stach@pengutronix.de
Subject: Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses
Date: Thu, 26 Apr 2018 15:14:53 +0200	[thread overview]
Message-ID: <20180426131404.GP4813@piout.net> (raw)
In-Reply-To: <1556510.Xu6NnhyFGZ@avalon>

Hi,

On 26/04/2018 15:45:44+0300, Laurent Pinchart wrote:
> Hi Daniel,
> 
> On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote:
> > On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote:
> > > It's been a while since we introduced drm_dev{get/put} functions
> > > to replace reference/unreference in drm subsystem for the
> > > consistency purpose. So, with this patch, let's just replace
> > > all current use cases of drm_dev_unref() with drm_dev_put and remove
> > > the function itself.
> > > 
> > > Coccinelle was used for mass-patching.
> > > 
> > > Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> > 
> > Thanks for doing this. Unfortunately drm moves pretty fast, so already a
> > conflict when I tried to apply this. Some drivers are also in their own
> > trees, so this might lead to more fun :-/
> > 
> > Can you pls split it up per-driver (just the directories under
> > drivers/gpu/drm/ is enough)? Final patch to remove the function might then
> > get stalled a bit ofc.
> 
> I requested a single patch instead of splitting it per driver, you might want 
> to blame me for that.
> 

Doesn't splitting the change per driver break bisectability unless there
is a guarantee that the change in include/drm/drm_drv.h is applied after
all the driver trees have been merged?


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-04-26 13:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 10:28 Vaishali Thakkar
2018-04-26 10:43 ` Laurent Pinchart
2018-04-26 12:06 ` Thierry Reding
2018-04-26 12:15 ` Boris Brezillon
2018-04-26 12:36 ` [Intel-gfx] " Daniel Vetter
     [not found]   ` <1556510.Xu6NnhyFGZ@avalon>
2018-04-26 12:57     ` Vaishali Thakkar
2018-04-26 13:14     ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426131404.GP4813@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=David1.Zhou@amd.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=alison.wang@freescale.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=benjamin.gaignard@linaro.org \
    --cc=brodkin@synopsys.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=inki.dae@samsung.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=kraxel@redhat.com \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=l.stach@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marex@denx.de \
    --cc=matthias.bgg@gmail.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=noralf@tronnes.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=p.zabel@pengutronix.de \
    --cc=philippe.cornu@st.com \
    --cc=puck.chen@hisilicon.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    --cc=sw0312.kim@samsung.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=vincent.abriou@st.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=vthakkar1994@gmail.com \
    --cc=wens@csie.org \
    --cc=yannick.fertre@st.com \
    --cc=z.liuxinliang@hisilicon.com \
    --cc=zourongrong@gmail.com \
    --subject='Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it'\''s uses' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).