LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Lars Melin <larsm17@gmail.com>
Cc: "Bjørn Mork" <bjorn@mork.no>, "Johan Hovold" <johan@kernel.org>,
"SZ Lin (林上智)" <sz.lin@moxa.com>, stable <stable@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dan Williams" <dcbw@redhat.com>
Subject: Re: [PATCH] USB: serial: option: adding support for ublox R410M
Date: Thu, 26 Apr 2018 18:12:28 +0200 [thread overview]
Message-ID: <20180426161228.GW4615@localhost> (raw)
In-Reply-To: <98b50ae7-b889-6811-476e-9cdc8a62a484@gmail.com>
On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote:
> On 4/26/2018 18:39, Lars Melin wrote:
> > On 4/26/2018 18:19, Bjørn Mork wrote:
> >> Anyway, Qualcomm based designs are definitely handled by both drivers.
> >> Using qcserial only makes sense if the interface layout matches one of
> >> the defined shared schemes, which currently are:
> >>
> >> QCSERIAL_G2K = 0, /* Gobi 2000 */
> >> QCSERIAL_G1K = 1, /* Gobi 1000 */
> >> QCSERIAL_SWI = 2, /* Sierra Wireless */
> >> QCSERIAL_HWI = 3, /* Huawei */
> >
> > It seems to me that this Quectel device matches the interface layout for
> > Gobi1K:
> >
> > * Gobi 1K USB layout:
> > * 0: DM/DIAG (use libqcdm from ModemManager for communication)
> > * 1: serial port (doesn't respond)
> > * 2: AT-capable modem port
> > * 3: QMI/net
> > */
> Ublox, not Quectel..
Yeah, but qcserial appears to select a different altsetting for the DM
port for Gobi 1000, an altsetting which this particular device does not
have.
I didn't re-read the full thread I referred to earlier, but I think in
it, Dan mentioned Gobi 1000 device requiring firmware to be loaded too.
So if it's not a G1K device, we probably shouldn't be using qcserial
even if the interface layout happens to match.
Thanks,
Johan
next prev parent reply other threads:[~2018-04-26 16:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 6:28 SZ Lin (林上智)
2018-04-26 7:09 ` Johan Hovold
2018-04-26 7:48 ` Lars Melin
2018-04-26 8:14 ` Johan Hovold
2018-04-26 11:19 ` Bjørn Mork
2018-04-26 11:39 ` Lars Melin
2018-04-26 11:40 ` Lars Melin
2018-04-26 16:12 ` Johan Hovold [this message]
2018-04-26 16:22 ` Lars Melin
2018-04-26 16:29 ` Johan Hovold
2018-04-26 19:12 ` Dan Williams
2018-04-27 2:14 ` SZ Lin (林上智)
2018-05-02 7:22 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426161228.GW4615@localhost \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=dcbw@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=larsm17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sz.lin@moxa.com \
--subject='Re: [PATCH] USB: serial: option: adding support for ublox R410M' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).