LKML Archive on
help / color / mirror / Atom feed
From: Keith Busch <>
To: Johannes Thumshirn <>
Cc: Linux NVMe Mailinglist <>,
	Linux Kernel Mailinglist <>,
	Christoph Hellwig <>, Sagi Grimberg <>
Subject: Re: [PATCH v2] nvme: change order of qid and cmdid in completion trace
Date: Thu, 26 Apr 2018 14:41:04 -0600	[thread overview]
Message-ID: <20180426204104.GA3094@localhost.localdomain> (raw)
In-Reply-To: <>

On Thu, Apr 26, 2018 at 02:25:15PM -0600, Johannes Thumshirn wrote:
> Keith reported that command submission and command completion
> tracepoints have the order of the cmdid and qid fields swapped.
> While it isn't easily possible to change the command submission
> tracepoint, as there is a regression test parsing it in blktests we
> can swap the command completion tracepoint to have the fields aligned.

It's the little things that matter. :)

Thanks, applied to nvme-4.18.

  reply	other threads:[~2018-04-26 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 20:25 Johannes Thumshirn
2018-04-26 20:41 ` Keith Busch [this message]
2018-04-27  5:20 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426204104.GA3094@localhost.localdomain \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] nvme: change order of qid and cmdid in completion trace' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).