LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] libata: Apply NOLPM quirk for SanDisk SD7UB3Q*G1001 SSDs
@ 2018-04-26 20:32 Hans de Goede
  2018-04-26 21:09 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2018-04-26 20:32 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Hans de Goede, linux-ide, linux-kernel, stable, Richard W . M . Jones

Richard Jones has reported that using med_power_with_dipm on a T450s
with a Sandisk SD7UB3Q256G1001 SSD (firmware version X2180501) is
causing the machine to hang.

Switching the LPM to max_performance fixes this, so it seems that
this Sandisk SSD does not handle LPM well.

Note in the past there have been bug-reports about the following
Sandisk models not working with min_power, so we may need to extend
the quirk list in the future: name - firmware
Sandisk SD6SB2M512G1022I   - X210400
Sandisk SD6PP4M-256G-1006  - A200906

Cc: stable@vger.kernel.org
Cc: Richard W.M. Jones <rjones@redhat.com>
Reported-and-tested-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 6e400ff2b5db..68596bd4cf06 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4552,6 +4552,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	/* This specific Samsung model/firmware-rev does not handle LPM well */
 	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
 
+	/* Sandisk devices which are known to not handle LPM well */
+	{ "SanDisk SD7UB3Q*G1001",	NULL,	ATA_HORKAGE_NOLPM, },
+
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500_*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
 						ATA_HORKAGE_ZERO_AFTER_TRIM, },
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libata: Apply NOLPM quirk for SanDisk SD7UB3Q*G1001 SSDs
  2018-04-26 20:32 [PATCH] libata: Apply NOLPM quirk for SanDisk SD7UB3Q*G1001 SSDs Hans de Goede
@ 2018-04-26 21:09 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2018-04-26 21:09 UTC (permalink / raw)
  To: Hans de Goede; +Cc: linux-ide, linux-kernel, stable, Richard W . M . Jones

On Thu, Apr 26, 2018 at 10:32:21PM +0200, Hans de Goede wrote:
> Richard Jones has reported that using med_power_with_dipm on a T450s
> with a Sandisk SD7UB3Q256G1001 SSD (firmware version X2180501) is
> causing the machine to hang.
> 
> Switching the LPM to max_performance fixes this, so it seems that
> this Sandisk SSD does not handle LPM well.
> 
> Note in the past there have been bug-reports about the following
> Sandisk models not working with min_power, so we may need to extend
> the quirk list in the future: name - firmware
> Sandisk SD6SB2M512G1022I   - X210400
> Sandisk SD6PP4M-256G-1006  - A200906
> 
> Cc: stable@vger.kernel.org
> Cc: Richard W.M. Jones <rjones@redhat.com>
> Reported-and-tested-by: Richard W.M. Jones <rjones@redhat.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied to libata/for-4.17-fixes.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-26 21:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 20:32 [PATCH] libata: Apply NOLPM quirk for SanDisk SD7UB3Q*G1001 SSDs Hans de Goede
2018-04-26 21:09 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).