LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-can@vger.kernel.org (open list:CAN NETWORK DRIVERS),
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Allwinner sunXi SoC support)
Subject: [PATCH 1/3] can: janz-ican3: fix ican3_xmit()'s return type
Date: Thu, 26 Apr 2018 23:13:36 +0200 [thread overview]
Message-ID: <20180426211339.30821-2-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20180426211339.30821-1-luc.vanoostenryck@gmail.com>
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
drivers/net/can/janz-ican3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
index adfdb66a4..02042cb09 100644
--- a/drivers/net/can/janz-ican3.c
+++ b/drivers/net/can/janz-ican3.c
@@ -1684,7 +1684,7 @@ static int ican3_stop(struct net_device *ndev)
return 0;
}
-static int ican3_xmit(struct sk_buff *skb, struct net_device *ndev)
+static netdev_tx_t ican3_xmit(struct sk_buff *skb, struct net_device *ndev)
{
struct ican3_dev *mod = netdev_priv(ndev);
struct can_frame *cf = (struct can_frame *)skb->data;
--
2.17.0
next prev parent reply other threads:[~2018-04-26 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 21:13 [PATCH 0/3] can: fix ndo_start_xmit()'s " Luc Van Oostenryck
2018-04-26 21:13 ` Luc Van Oostenryck [this message]
2018-04-26 21:13 ` [PATCH 2/3] can: sun4i: fix sun4ican_start_xmit()'s " Luc Van Oostenryck
2018-04-26 21:13 ` [PATCH 3/3] can: xilinx: fix xcan_start_xmit()'s " Luc Van Oostenryck
2018-04-27 7:49 ` Michal Simek
2018-04-27 7:55 ` Marc Kleine-Budde
2018-04-27 8:03 ` Michal Simek
2018-04-27 7:21 ` [PATCH 0/3] can: fix ndo_start_xmit()'s " Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426211339.30821-2-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=michal.simek@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
--cc=wg@grandegger.com \
--subject='Re: [PATCH 1/3] can: janz-ican3: fix ican3_xmit()'\''s return type' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).