LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kys@microsoft.com
Cc: olaf@aepfle.de, sthemmin@microsoft.com,
gregkh@linuxfoundation.org, jasowang@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org, Michael.H.Kelley@microsoft.com,
hpa@zytor.com, apw@canonical.com, devel@linuxdriverproject.org,
tglx@linutronix.de, vkuznets@redhat.com
Subject: Re: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments
Date: Fri, 27 Apr 2018 00:31:49 +0300 [thread overview]
Message-ID: <20180426213148.d5udlgzgbvtym25p@mwanda> (raw)
In-Reply-To: <20180425181250.8740-2-kys@linuxonhyperv.com>
On Wed, Apr 25, 2018 at 11:12:47AM -0700, kys@linuxonhyperv.com wrote:
> +/*
> + * IPI implementation on Hyper-V.
> + */
> +
> +static int __send_ipi_mask(const struct cpumask *mask, int vector)
> +{
> + int cur_cpu, vcpu;
> + struct ipi_arg_non_ex **arg;
> + struct ipi_arg_non_ex *ipi_arg;
> + int ret = 1;
Not specifically related to this patch, but hv code sometimes returns 1
on error or U64_MAX. It's slightly magical. Maybe
HV_STATUS_INVALID_HYPERCALL_INPUT (3) would be more appropriate? Or we
could make a new more generic error code:
#define HV_STATUS_INVALID 1
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-04-26 21:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 18:11 [PATCH 0/5] X86: Hyper-V: APIC enlightenments kys
2018-04-25 18:12 ` [PATCH 1/5] X86: Hyper-V: Enlighten APIC access kys
2018-04-25 18:12 ` [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments kys
2018-04-26 21:31 ` Dan Carpenter [this message]
2018-04-27 6:34 ` KY Srinivasan
2018-04-26 22:08 ` Thomas Gleixner
2018-04-27 6:11 ` KY Srinivasan
2018-04-26 22:54 ` Michael Kelley (EOSG)
2018-04-27 6:31 ` KY Srinivasan
2018-04-27 6:24 ` kbuild test robot
2018-04-27 11:21 ` kbuild test robot
2018-04-27 11:55 ` kbuild test robot
2018-04-25 18:12 ` [PATCH 3/5] X86: Hyper-V: Enhanced IPI enlightenment kys
2018-04-26 22:16 ` Thomas Gleixner
2018-04-27 6:24 ` KY Srinivasan
2018-04-26 23:25 ` Michael Kelley (EOSG)
2018-04-25 18:12 ` [PATCH 4/5] X86: Hyper-V: Consolidate code for converting cpumask to vpset kys
2018-04-26 22:21 ` Thomas Gleixner
2018-04-25 18:12 ` [PATCH 5/5] X86: Hyper-V: Consolidate the allocation of the hypercall input page kys
2018-04-26 22:23 ` Thomas Gleixner
2018-04-27 6:29 ` KY Srinivasan
2018-04-27 10:58 ` Thomas Gleixner
2018-04-27 11:50 ` kbuild test robot
2018-04-26 21:49 ` [PATCH 1/5] X86: Hyper-V: Enlighten APIC access Thomas Gleixner
2018-04-27 5:52 ` KY Srinivasan
2018-04-26 22:15 ` Michael Kelley (EOSG)
2018-04-26 22:55 ` Thomas Gleixner
2018-04-27 5:44 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426213148.d5udlgzgbvtym25p@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Michael.H.Kelley@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--subject='Re: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).