LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ptp_pch: use helpers function for converting between ns and timespec
@ 2018-04-27  7:36 YueHaibing
  2018-04-27 13:26 ` Richard Cochran
  2018-04-27 19:22 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-04-27  7:36 UTC (permalink / raw)
  To: richardcochran, davem; +Cc: netdev, linux-kernel, YueHaibing

use ns_to_timespec64() and timespec64_to_ns() instead of open coding

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/ptp/ptp_pch.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c
index b328517..78ccf93 100644
--- a/drivers/ptp/ptp_pch.c
+++ b/drivers/ptp/ptp_pch.c
@@ -452,7 +452,6 @@ static int ptp_pch_adjtime(struct ptp_clock_info *ptp, s64 delta)
 static int ptp_pch_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts)
 {
 	u64 ns;
-	u32 remainder;
 	unsigned long flags;
 	struct pch_dev *pch_dev = container_of(ptp, struct pch_dev, caps);
 	struct pch_ts_regs __iomem *regs = pch_dev->regs;
@@ -461,8 +460,7 @@ static int ptp_pch_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts)
 	ns = pch_systime_read(regs);
 	spin_unlock_irqrestore(&pch_dev->register_lock, flags);
 
-	ts->tv_sec = div_u64_rem(ns, 1000000000, &remainder);
-	ts->tv_nsec = remainder;
+	*ts = ns_to_timespec64(ns);
 	return 0;
 }
 
@@ -474,8 +472,7 @@ static int ptp_pch_settime(struct ptp_clock_info *ptp,
 	struct pch_dev *pch_dev = container_of(ptp, struct pch_dev, caps);
 	struct pch_ts_regs __iomem *regs = pch_dev->regs;
 
-	ns = ts->tv_sec * 1000000000ULL;
-	ns += ts->tv_nsec;
+	ns = timespec64_to_ns(ts);
 
 	spin_lock_irqsave(&pch_dev->register_lock, flags);
 	pch_systime_write(regs, ns);
-- 
2.7.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ptp_pch: use helpers function for converting between ns and timespec
  2018-04-27  7:36 [PATCH] ptp_pch: use helpers function for converting between ns and timespec YueHaibing
@ 2018-04-27 13:26 ` Richard Cochran
  2018-04-27 19:22 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2018-04-27 13:26 UTC (permalink / raw)
  To: YueHaibing; +Cc: davem, netdev, linux-kernel

On Fri, Apr 27, 2018 at 03:36:18PM +0800, YueHaibing wrote:
> use ns_to_timespec64() and timespec64_to_ns() instead of open coding

Acked-by: Richard Cochran <richardcochran@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ptp_pch: use helpers function for converting between ns and timespec
  2018-04-27  7:36 [PATCH] ptp_pch: use helpers function for converting between ns and timespec YueHaibing
  2018-04-27 13:26 ` Richard Cochran
@ 2018-04-27 19:22 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-04-27 19:22 UTC (permalink / raw)
  To: yuehaibing; +Cc: richardcochran, netdev, linux-kernel

From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 27 Apr 2018 15:36:18 +0800

> use ns_to_timespec64() and timespec64_to_ns() instead of open coding
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied to net-next, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-27 19:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27  7:36 [PATCH] ptp_pch: use helpers function for converting between ns and timespec YueHaibing
2018-04-27 13:26 ` Richard Cochran
2018-04-27 19:22 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).