LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: mt7621-eth: fix line over 80 char / extra line in mtk_set_link_ksettings()
@ 2018-04-27 0:29 Jefferson Capovilla
2018-04-29 13:24 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jefferson Capovilla @ 2018-04-27 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
Fix 'line over 80 characters' issue found by checkpatch.pl script in
mtk_set_link_ksettings().
Fix extra line before end of function.
Signed-off-by: Jefferson Capovilla <jefcap@gmail.com>
---
drivers/staging/mt7621-eth/ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-eth/ethtool.c b/drivers/staging/mt7621-eth/ethtool.c
index 38ba0c0..e9f4092 100644
--- a/drivers/staging/mt7621-eth/ethtool.c
+++ b/drivers/staging/mt7621-eth/ethtool.c
@@ -52,7 +52,8 @@ static int mtk_set_link_ksettings(struct net_device *dev,
mac->phy_dev = mac->hw->phy->phy[cmd->base.phy_address];
mac->phy_flags = MTK_PHY_FLAG_PORT;
} else if (mac->hw->mii_bus) {
- mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus, cmd->base.phy_address);
+ mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus,
+ cmd->base.phy_address);
if (!mac->phy_dev)
return -ENODEV;
mac->phy_flags = MTK_PHY_FLAG_ATTACH;
@@ -62,7 +63,6 @@ static int mtk_set_link_ksettings(struct net_device *dev,
}
return phy_ethtool_ksettings_set(mac->phy_dev, cmd);
-
}
static void mtk_get_drvinfo(struct net_device *dev,
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: mt7621-eth: fix line over 80 char / extra line in mtk_set_link_ksettings()
2018-04-27 0:29 [PATCH] staging: mt7621-eth: fix line over 80 char / extra line in mtk_set_link_ksettings() Jefferson Capovilla
@ 2018-04-29 13:24 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-04-29 13:24 UTC (permalink / raw)
To: Jefferson Capovilla; +Cc: devel, linux-kernel
On Thu, Apr 26, 2018 at 09:29:09PM -0300, Jefferson Capovilla wrote:
> Fix 'line over 80 characters' issue found by checkpatch.pl script in
> mtk_set_link_ksettings().
> Fix extra line before end of function.
That is two different things, please break this up into two different
emails and send them as a patch series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-29 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 0:29 [PATCH] staging: mt7621-eth: fix line over 80 char / extra line in mtk_set_link_ksettings() Jefferson Capovilla
2018-04-29 13:24 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).