LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: dan.j.williams@intel.com, eric.long@spreadtrum.com,
	broonie@kernel.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration
Date: Fri, 27 Apr 2018 11:54:06 +0530	[thread overview]
Message-ID: <20180427062405.GY6014@localhost> (raw)
In-Reply-To: <30ff22774f045db654d5e784716c3ee69e00775d.1524054807.git.baolin.wang@linaro.org>

On Thu, Apr 19, 2018 at 10:00:49AM +0800, Baolin Wang wrote:

> +/*
> + * struct sprd_dma_config - DMA configuration structure
> + * @src_addr: the physical address where DMA slave data should be read
> + * @dst_addr: the physical address where DMA slave data should be written
> + * @fragment_len: specify one fragment transfer length
> + * @block_len: specify one block transfer length
> + * @transcation_len: specify one transcation transfer length
> + * @src_step: source transfer step
> + * @dst_step: destination transfer step
> + * @src_datawidth: source transfer data width
> + * @dst_datawidth: destination transfer data width
> + * @wrap_ptr: wrap pointer address, once the transfer address reaches the
> + * 'wrap_ptr', the next transfer address will jump to the 'wrap_to' address.
> + * @wrap_to: wrap jump to address
> + * @req_mode: specify the DMA request mode
> + * @int_mode: specify the DMA interrupt type
> + * @slave_id: slave channel requester id
> + */
> +struct sprd_dma_config {

can you please not duplicate the dma_slave_config here. If you want to save
your own values then please embed dma_slave_config here
-- 
~Vinod

  reply	other threads:[~2018-04-27  6:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  2:00 [PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
2018-04-19  2:00 ` [PATCH v2 2/5] dmaengine: sprd: Define the DMA data width type Baolin Wang
2018-04-27  6:25   ` Vinod Koul
2018-04-19  2:00 ` [PATCH v2 3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file Baolin Wang
2018-04-27  6:26   ` Vinod Koul
2018-04-19  2:00 ` [PATCH v2 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang
2018-04-27  6:24   ` Vinod Koul [this message]
2018-04-30  8:18     ` Baolin Wang
2018-04-19  2:00 ` [PATCH v2 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
2018-04-27  6:25 ` [PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427062405.GY6014@localhost \
    --to=vinod.koul@intel.com \
    --cc=baolin.wang@linaro.org \
    --cc=broonie@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=eric.long@spreadtrum.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v2 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).