LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Efstratios Gavas <xtrat@elg.io>
Cc: devel@driverdev.osuosl.org,
	Thibaut SAUTEREAU <thibaut.sautereau@telecom-sudparis.eu>,
	Aviv Palivoda <palaviv@gmail.com>,
	AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: prism2sta: fixed indent coding style issues.
Date: Fri, 27 Apr 2018 08:58:01 +0200	[thread overview]
Message-ID: <20180427065801.GC4361@kroah.com> (raw)
In-Reply-To: <958b53ef.AMIAAAYVaKUAAAAAAAAAAADFWYgAAAASzIYAAAAAAArW7ABa4rkQ@mailjet.com>

On Fri, Apr 27, 2018 at 05:45:07AM +0000, Efstratios Gavas wrote:
> Fixed coding style issues.
> Signed-off-by: Efstratios Gavas <xtrat@elg.io>

We need a blank line before the signed-off-by: line in order to properly
work.

Also, please be much more specific in your changelog text as to what you
are doing here.

And finally, you sent 2 copies of this patch, but no way to tell which
one is the "correct" one.

Please fix this up and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-04-27  6:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27  5:45 Efstratios Gavas
2018-04-27  6:58 ` Greg Kroah-Hartman [this message]
2018-04-27 21:33   ` [PATCHv3] staging: " Efstratios Gavas
2018-04-28  6:01     ` Greg Kroah-Hartman
2018-04-28 19:51       ` Efstratios Gavas
2018-04-27 21:33   ` Efstratios Gavas
  -- strict thread matches above, loose matches on Subject: below --
2018-04-27  5:45 [PATCH] Staging: " Efstratios Gavas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427065801.GC4361@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abdallah.meziti.pro@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=palaviv@gmail.com \
    --cc=thibaut.sautereau@telecom-sudparis.eu \
    --cc=xtrat@elg.io \
    --subject='Re: [PATCH] Staging: wlan-ng: prism2sta: fixed indent coding style issues.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).