LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joelaf@google.com>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zilstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Thomas Glexiner <tglx@linutronix.de>,
	Boqun Feng <boqun.feng@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Fenguang Wu <fengguang.wu@intel.com>,
	Baohong Liu <baohong.liu@intel.com>,
	Vedang Patel <vedang.patel@intel.com>,
	"Cc: Android Kernel" <kernel-team@android.com>
Subject: Re: [PATCH RFC] tracepoint: Introduce tracepoint callbacks executing with preempt on
Date: Fri, 27 Apr 2018 12:22:01 -0400	[thread overview]
Message-ID: <20180427122201.75abc313@gandalf.local.home> (raw)
In-Reply-To: <CAJWu+or9GJwkDK9+842YbobG3=xVW-PgqS=uE5P2xFbDhmqxEQ@mail.gmail.com>

On Fri, 27 Apr 2018 09:14:30 -0700
Joel Fernandes <joelaf@google.com> wrote:

> > Hmmm...  Do I need to create a _notrace variant of srcu_read_lock()
> > and srcu_read_unlock()?  
> 
> That shouldn't be needed. For the rcu_read_lock_sched case, there is a
> preempt_disable which needs to be a notrace, but for the srcu one,
> since we don't do that, I think it should be fine.

Actually, I think I may agree here too. Because the _notrace is for
function tracing, and it shouldn't affect it. If people don't want it
traced, they could add those functions to the list in the notrace file.

-- Steve

  reply	other threads:[~2018-04-27 16:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27  4:26 [PATCH RFC] tracepoint: Introduce tracepoint callbacks executing with preempt on Joel Fernandes
2018-04-27 14:26 ` Mathieu Desnoyers
2018-04-27 14:47   ` Steven Rostedt
2018-04-27 15:38     ` Paul E. McKenney
2018-04-27 15:40       ` Steven Rostedt
2018-04-27 15:43         ` Mathieu Desnoyers
2018-04-27 16:08           ` Steven Rostedt
2018-04-27 15:58         ` Paul E. McKenney
2018-04-27 15:42     ` Mathieu Desnoyers
2018-04-27 16:07       ` Steven Rostedt
2018-04-27 16:30     ` Joel Fernandes
2018-04-27 16:37       ` Steven Rostedt
2018-04-27 18:11         ` Joel Fernandes
2018-04-27 18:42           ` Mathieu Desnoyers
2018-04-27 15:57 ` Paul E. McKenney
2018-04-27 16:13   ` Steven Rostedt
2018-04-27 16:22     ` Joel Fernandes
2018-04-27 16:44     ` Paul E. McKenney
2018-04-27 16:14   ` Joel Fernandes
2018-04-27 16:22     ` Steven Rostedt [this message]
2018-04-27 16:45       ` Paul E. McKenney
2018-04-27 16:46         ` Steven Rostedt
2018-04-27 17:00           ` Paul E. McKenney
2018-04-27 17:05             ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427122201.75abc313@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=baohong.liu@intel.com \
    --cc=boqun.feng@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=joelaf@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tom.zanussi@linux.intel.com \
    --cc=vedang.patel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).