LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S . Miller" <davem@davemloft.net>,
	Allan Nielsen <Allan.Nielsen@microsemi.com>,
	razvan.stefanescu@nxp.com, po.liu@nxp.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH net-next v2 4/7] net: mscc: Add initial Ocelot switch support
Date: Fri, 27 Apr 2018 15:44:00 +0200	[thread overview]
Message-ID: <20180427134400.GA4813@piout.net> (raw)
In-Reply-To: <20180426210915.GE23481@lunn.ch>

On 26/04/2018 23:09:15+0200, Andrew Lunn wrote:
> > +/* Checks if the net_device instance given to us originate from our driver. */
> > +static bool ocelot_netdevice_dev_check(const struct net_device *dev)
> > +{
> > +	return dev->netdev_ops == &ocelot_port_netdev_ops;
> > +}
> 
> This is probably O.K. now, but when you add support for controlling
> the switch over PCIe, i think it breaks. A board could have two
> switches...
> 
> It might be possible to do something with dev->parent. All ports of a
> switch should have the same parent.
> 

Actually, that is fine because it simply ensures netdev_priv(dev); is a
struct ocelot_port.

Later on, we get ocelot_port->ocelot and do the right thing.

The only thing that would not be working when having multiple of those
switches on the same platform would be having interfaces from different
switches in the same bridge. Anyway, this is definitively not something
we want because of the limited bandwidth of the CPU port.


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-27 13:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 19:59 [PATCH net-next v2 0/7] Microsemi Ocelot Ethernet " Alexandre Belloni
2018-04-26 19:59 ` [PATCH net-next v2 1/7] dt-bindings: net: add DT bindings for Microsemi MIIM Alexandre Belloni
2018-04-27 20:08   ` Rob Herring
2018-04-26 19:59 ` [PATCH net-next v2 2/7] net: mscc: Add MDIO driver Alexandre Belloni
2018-04-26 20:46   ` Andrew Lunn
2018-04-26 19:59 ` [PATCH net-next v2 3/7] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch Alexandre Belloni
2018-04-27 20:10   ` Rob Herring
2018-04-26 19:59 ` [PATCH net-next v2 4/7] net: mscc: Add initial Ocelot switch support Alexandre Belloni
2018-04-26 21:09   ` Andrew Lunn
2018-04-27 13:44     ` Alexandre Belloni [this message]
2018-04-28 19:42   ` kbuild test robot
2018-04-28 20:42   ` kbuild test robot
2018-04-26 19:59 ` [PATCH net-next v2 5/7] MIPS: mscc: Add switch to ocelot Alexandre Belloni
2018-04-26 20:51   ` Andrew Lunn
2018-04-27  7:40     ` Alexandre Belloni
2018-04-26 19:59 ` [PATCH net-next v2 6/7] MIPS: mscc: connect phys to ports on ocelot_pcb123 Alexandre Belloni
2018-04-26 19:59 ` [PATCH net-next v2 7/7] MAINTAINERS: Add entry for Microsemi Ethernet switches Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427134400.GA4813@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=Allan.Nielsen@microsemi.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=netdev@vger.kernel.org \
    --cc=po.liu@nxp.com \
    --cc=razvan.stefanescu@nxp.com \
    --cc=thomas.petazzoni@bootlin.com \
    --subject='Re: [PATCH net-next v2 4/7] net: mscc: Add initial Ocelot switch support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).