From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZoPRVyoqbCKaqD0S4TTbXNLBqzgpoTiHKIRvanOvVrwGG55PGU4mWPaDRo0Ur7aqdosq/27 ARC-Seal: i=1; a=rsa-sha256; t=1524837641; cv=none; d=google.com; s=arc-20160816; b=RW03c2oP2NpWylmmH0RVpIt1/vj6Beii9EDnOZALwM3whTRcPyeUBmG9WtP36qjSZF s8MVfaB0iIsmgwr5QuWbibLc/TzANeL9nwdReMkIHpjEaijpxWypagTZYZc0P1BY9Jik JecWagrziBNjub2g2bKoGFBKSskaaMAb2DO1/Mzfnoj3vQkP5D2bZhQVly0qMdJwKP32 NCaP8ygQBUvp6uslcIfPv3kFOP6oWljHJhztKi4Yk6RXEEXBq17j7kstmI/RD9FgMPew b23Ch6qe1vPPvZjYBvPj3KwAc3u6Yms4wyQN7O+eb3tQv0CIuGa5hOQEzqc5KUZtMj61 BMXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:arc-authentication-results; bh=6OALhr3DT6rQ0bTknnDjaM3JNb6XmOY8ILq7BSHfiUo=; b=FE4IwmwdO0Q/fclPw+OG4w9TeYn2O4/wPhKtJRauulAtDSiD9C+v9jQCe9QMgu/IKA dnrDf3Hu1JxLPAjVaKtZBd8zdOP9T3a5TqTBaB7lrXeupA3yXu1BFVYCZRGWwzuRQwGS XoFOzDRjpFpFa9F283J1QqcrLRfs85fMBWIFVd3Y30SF4web79fqgMyCQr8ojZbqwnTF q85trHmicn8azl+j+jUv6kgI69yyi5Saszc81zhn7/zrWnvIbHJUqh1TJXXb8/n59dHx p42QGtxozEChiYqSookg98vVFx3GBH7GZVkINjqsw+gLaU9QnAvLVOrW1smKfrigSvgK +iqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of srs0=4/0d=hq=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=4/0d=HQ=linuxfoundation.org=gregkh@kernel.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of srs0=4/0d=hq=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=4/0d=HQ=linuxfoundation.org=gregkh@kernel.org DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB85A2189D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Olsa , Alexander Shishkin , Andi Kleen , "H. Peter Anvin" , Namhyung Kim , Peter Zijlstra , Stephane Eranian , Thomas Gleixner , syzkaller-bugs@googlegroups.com, x86@kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 4.4 03/50] perf: Return proper values for user stack errors Date: Fri, 27 Apr 2018 15:58:05 +0200 Message-Id: <20180427135655.846786908@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427135655.623669681@linuxfoundation.org> References: <20180427135655.623669681@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1598908138120907757?= X-GMAIL-MSGID: =?utf-8?q?1598908154306753331?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiri Olsa commit 78b562fbfa2cf0a9fcb23c3154756b690f4905c1 upstream. Return immediately when we find issue in the user stack checks. The error value could get overwritten by following check for PERF_SAMPLE_REGS_INTR. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Andi Kleen Cc: H. Peter Anvin Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Thomas Gleixner Cc: syzkaller-bugs@googlegroups.com Cc: x86@kernel.org Fixes: 60e2364e60e8 ("perf: Add ability to sample machine state on interrupt") Link: http://lkml.kernel.org/r/20180415092352.12403-1-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- kernel/events/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8133,9 +8133,9 @@ static int perf_copy_attr(struct perf_ev * __u16 sample size limit. */ if (attr->sample_stack_user >= USHRT_MAX) - ret = -EINVAL; + return -EINVAL; else if (!IS_ALIGNED(attr->sample_stack_user, sizeof(u64))) - ret = -EINVAL; + return -EINVAL; } if (attr->sample_type & PERF_SAMPLE_REGS_INTR)