LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
@ 2018-04-27 14:03 Alex Elder
  2018-09-28 11:41 ` Alex Elder
  0 siblings, 1 reply; 10+ messages in thread
From: Alex Elder @ 2018-04-27 14:03 UTC (permalink / raw)
  To: andy.gross, david.brown; +Cc: linux-arm-msm, linux-soc, linux-kernel

Add a prompt to the "tristate" attribute in the Kconfig file in
which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
without it.

Signed-off-by: Alex Elder <elder@linaro.org>
---
 drivers/soc/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 5c4535b545cc..81a501765cd9 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -36,7 +36,7 @@ config QCOM_PM
 	  low power modes.
 
 config QCOM_QMI_HELPERS
-	tristate
+	tristate "Qualcomm QMI Helpers"
 	depends on ARCH_QCOM && NET
 	help
 	  Helper library for handling QMI encoded messages.  QMI encoded
-- 
2.14.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
  2018-04-27 14:03 [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS Alex Elder
@ 2018-09-28 11:41 ` Alex Elder
  2018-09-28 12:26   ` Niklas Cassel
  0 siblings, 1 reply; 10+ messages in thread
From: Alex Elder @ 2018-09-28 11:41 UTC (permalink / raw)
  To: andy.gross, david.brown; +Cc: linux-arm-msm, linux-soc, linux-kernel

Was there something wrong with this patch?  I sent it a long time
ago but it still applies cleanly.  I can re-send if you like.

					-Alex

On 04/27/2018 09:03 AM, Alex Elder wrote:
> Add a prompt to the "tristate" attribute in the Kconfig file in
> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> without it.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
>  drivers/soc/qcom/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 5c4535b545cc..81a501765cd9 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -36,7 +36,7 @@ config QCOM_PM
>  	  low power modes.
>  
>  config QCOM_QMI_HELPERS
> -	tristate
> +	tristate "Qualcomm QMI Helpers"
>  	depends on ARCH_QCOM && NET
>  	help
>  	  Helper library for handling QMI encoded messages.  QMI encoded
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
  2018-09-28 11:41 ` Alex Elder
@ 2018-09-28 12:26   ` Niklas Cassel
  2018-09-28 13:23     ` Alex Elder
  0 siblings, 1 reply; 10+ messages in thread
From: Niklas Cassel @ 2018-09-28 12:26 UTC (permalink / raw)
  To: Alex Elder
  Cc: andy.gross, david.brown, linux-arm-msm, linux-soc, linux-kernel

On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote:
> Was there something wrong with this patch?  I sent it a long time
> ago but it still applies cleanly.  I can re-send if you like.

Hello Alex,

This patch does not apply on top of
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next


When you don't specify a string for a Kconfig, then you won't be able to
select it via menuconfig, only through other Kconfigs, e.g.:
$ git grep QCOM_QMI_HELPERS
drivers/remoteproc/Kconfig:     select QCOM_QMI_HELPERS

What Kconfig is it that needs QCOM_QMI_HELPERS?
Why do you need to make is selectable via menuconfig?
Isn't it sufficient to add a "select QCOM_QMI_HELPERS" to that Kconfig?


Kind regards,
Niklas

> 
> 					-Alex
> 
> On 04/27/2018 09:03 AM, Alex Elder wrote:
> > Add a prompt to the "tristate" attribute in the Kconfig file in
> > which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> > without it.
> > 
> > Signed-off-by: Alex Elder <elder@linaro.org>
> > ---
> >  drivers/soc/qcom/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> > index 5c4535b545cc..81a501765cd9 100644
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
> > @@ -36,7 +36,7 @@ config QCOM_PM
> >  	  low power modes.
> >  
> >  config QCOM_QMI_HELPERS
> > -	tristate
> > +	tristate "Qualcomm QMI Helpers"
> >  	depends on ARCH_QCOM && NET
> >  	help
> >  	  Helper library for handling QMI encoded messages.  QMI encoded
> > 
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
  2018-09-28 12:26   ` Niklas Cassel
@ 2018-09-28 13:23     ` Alex Elder
  2018-09-28 14:00       ` Niklas Cassel
  2018-09-28 17:21       ` Bjorn Andersson
  0 siblings, 2 replies; 10+ messages in thread
From: Alex Elder @ 2018-09-28 13:23 UTC (permalink / raw)
  To: Niklas Cassel
  Cc: andy.gross, david.brown, linux-arm-msm, linux-soc, linux-kernel

On 09/28/2018 07:26 AM, Niklas Cassel wrote:
> On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote:
>> Was there something wrong with this patch?  I sent it a long time
>> ago but it still applies cleanly.  I can re-send if you like.
> 
> Hello Alex,
> 
> This patch does not apply on top of
> https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next

Sorry, I sent this before I tracked down where Andy's for-next
tree was.  It applied OK to linus/master.

> When you don't specify a string for a Kconfig, then you won't be able to
> select it via menuconfig, only through other Kconfigs, e.g.:
> $ git grep QCOM_QMI_HELPERS
> drivers/remoteproc/Kconfig:     select QCOM_QMI_HELPERS
> 
> What Kconfig is it that needs QCOM_QMI_HELPERS?

IPA, which is not yet merged.

The entry in "drivers/soc/qcom/Kconfig" for this option includes
help text, so I presume it was an oversight not to include a
string (prompt).  It is the only non-trivial entry in that file
that does not include one.  Why should this entry not be listed
in menus?

> Why do you need to make is selectable via menuconfig?
> Isn't it sufficient to add a "select QCOM_QMI_HELPERS" to that Kconfig?

I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS.  I could
change that to select it instead but I still think this entry
should be changed.

I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig
also depends on--rather than selects--QCOM_QMI_HELPERS.

					-Alex

> 
> Kind regards,
> Niklas
> 
>>
>> 					-Alex
>>
>> On 04/27/2018 09:03 AM, Alex Elder wrote:
>>> Add a prompt to the "tristate" attribute in the Kconfig file in
>>> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
>>> without it.
>>>
>>> Signed-off-by: Alex Elder <elder@linaro.org>
>>> ---
>>>  drivers/soc/qcom/Kconfig | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>>> index 5c4535b545cc..81a501765cd9 100644
>>> --- a/drivers/soc/qcom/Kconfig
>>> +++ b/drivers/soc/qcom/Kconfig
>>> @@ -36,7 +36,7 @@ config QCOM_PM
>>>  	  low power modes.
>>>  
>>>  config QCOM_QMI_HELPERS
>>> -	tristate
>>> +	tristate "Qualcomm QMI Helpers"
>>>  	depends on ARCH_QCOM && NET
>>>  	help
>>>  	  Helper library for handling QMI encoded messages.  QMI encoded
>>>
>>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
  2018-09-28 13:23     ` Alex Elder
@ 2018-09-28 14:00       ` Niklas Cassel
  2018-09-28 17:21       ` Bjorn Andersson
  1 sibling, 0 replies; 10+ messages in thread
From: Niklas Cassel @ 2018-09-28 14:00 UTC (permalink / raw)
  To: Alex Elder, bjorn.andersson, srinivas.kandagatla
  Cc: andy.gross, david.brown, linux-arm-msm, linux-soc, linux-kernel

On Fri, Sep 28, 2018 at 08:23:03AM -0500, Alex Elder wrote:
> On 09/28/2018 07:26 AM, Niklas Cassel wrote:
> > On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote:
> >> Was there something wrong with this patch?  I sent it a long time
> >> ago but it still applies cleanly.  I can re-send if you like.
> > 
> > Hello Alex,
> > 
> > This patch does not apply on top of
> > https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next
> 
> Sorry, I sent this before I tracked down where Andy's for-next
> tree was.  It applied OK to linus/master.
> 
> > When you don't specify a string for a Kconfig, then you won't be able to
> > select it via menuconfig, only through other Kconfigs, e.g.:
> > $ git grep QCOM_QMI_HELPERS
> > drivers/remoteproc/Kconfig:     select QCOM_QMI_HELPERS
> > 
> > What Kconfig is it that needs QCOM_QMI_HELPERS?
> 
> IPA, which is not yet merged.
> 
> The entry in "drivers/soc/qcom/Kconfig" for this option includes
> help text, so I presume it was an oversight not to include a
> string (prompt).  It is the only non-trivial entry in that file
> that does not include one.  Why should this entry not be listed
> in menus?

I see. Indeed it is a bit confusing that it has a help text.

> 
> > Why do you need to make is selectable via menuconfig?
> > Isn't it sufficient to add a "select QCOM_QMI_HELPERS" to that Kconfig?
> 
> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS.  I could
> change that to select it instead but I still think this entry
> should be changed.
> 
> I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig
> also depends on--rather than selects--QCOM_QMI_HELPERS.

I would have expected SLIM_QCOM_NGD_CTRL to select rather than depend.
But then it is also weird that QCOM_QMI_HELPERS has a help text.

I guess Bjorn should answer how this Kconfig was intended to
be used, because right now it is kind of ambiguous.


Kind regards,
Niklas

> 
> 					-Alex
> 
> > 
> > Kind regards,
> > Niklas
> > 
> >>
> >> 					-Alex
> >>
> >> On 04/27/2018 09:03 AM, Alex Elder wrote:
> >>> Add a prompt to the "tristate" attribute in the Kconfig file in
> >>> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> >>> without it.
> >>>
> >>> Signed-off-by: Alex Elder <elder@linaro.org>
> >>> ---
> >>>  drivers/soc/qcom/Kconfig | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> >>> index 5c4535b545cc..81a501765cd9 100644
> >>> --- a/drivers/soc/qcom/Kconfig
> >>> +++ b/drivers/soc/qcom/Kconfig
> >>> @@ -36,7 +36,7 @@ config QCOM_PM
> >>>  	  low power modes.
> >>>  
> >>>  config QCOM_QMI_HELPERS
> >>> -	tristate
> >>> +	tristate "Qualcomm QMI Helpers"
> >>>  	depends on ARCH_QCOM && NET
> >>>  	help
> >>>  	  Helper library for handling QMI encoded messages.  QMI encoded
> >>>
> >>
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
  2018-09-28 13:23     ` Alex Elder
  2018-09-28 14:00       ` Niklas Cassel
@ 2018-09-28 17:21       ` Bjorn Andersson
  2018-09-28 17:29         ` Alex Elder
  1 sibling, 1 reply; 10+ messages in thread
From: Bjorn Andersson @ 2018-09-28 17:21 UTC (permalink / raw)
  To: Alex Elder
  Cc: Niklas Cassel, andy.gross, david.brown, linux-arm-msm, linux-soc,
	linux-kernel

On Fri 28 Sep 06:23 PDT 2018, Alex Elder wrote:

> On 09/28/2018 07:26 AM, Niklas Cassel wrote:
> > On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote:
> >> Was there something wrong with this patch?  I sent it a long time
> >> ago but it still applies cleanly.  I can re-send if you like.
> > 
> > Hello Alex,
> > 
> > This patch does not apply on top of
> > https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next
> 
> Sorry, I sent this before I tracked down where Andy's for-next
> tree was.  It applied OK to linus/master.
> 
> > When you don't specify a string for a Kconfig, then you won't be able to
> > select it via menuconfig, only through other Kconfigs, e.g.:
> > $ git grep QCOM_QMI_HELPERS
> > drivers/remoteproc/Kconfig:     select QCOM_QMI_HELPERS
> > 
> > What Kconfig is it that needs QCOM_QMI_HELPERS?
> 
> IPA, which is not yet merged.
> 
> The entry in "drivers/soc/qcom/Kconfig" for this option includes
> help text, so I presume it was an oversight not to include a
> string (prompt).  It is the only non-trivial entry in that file
> that does not include one.  Why should this entry not be listed
> in menus?
> 
> > Why do you need to make is selectable via menuconfig?

I made it this way because I don't see a reason for anyone to ever
select this config option if there isn't a client available - and
clients that "depends on" this simply forces the developer to find the
QMI helpers in menuconfig and enable it manually.

> > Isn't it sufficient to add a "select QCOM_QMI_HELPERS" to that Kconfig?
> 
> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS.  I could
> change that to select it instead but I still think this entry
> should be changed.
> 

Why do you say it needs to change? I tested this by just adding a
"select QCOM_QMI_HELPERS" in my client drivers.

> I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig
> also depends on--rather than selects--QCOM_QMI_HELPERS.
> 

That's wrong.

Regards,
Bjorn

> 					-Alex
> 
> > 
> > Kind regards,
> > Niklas
> > 
> >>
> >> 					-Alex
> >>
> >> On 04/27/2018 09:03 AM, Alex Elder wrote:
> >>> Add a prompt to the "tristate" attribute in the Kconfig file in
> >>> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> >>> without it.
> >>>
> >>> Signed-off-by: Alex Elder <elder@linaro.org>
> >>> ---
> >>>  drivers/soc/qcom/Kconfig | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> >>> index 5c4535b545cc..81a501765cd9 100644
> >>> --- a/drivers/soc/qcom/Kconfig
> >>> +++ b/drivers/soc/qcom/Kconfig
> >>> @@ -36,7 +36,7 @@ config QCOM_PM
> >>>  	  low power modes.
> >>>  
> >>>  config QCOM_QMI_HELPERS
> >>> -	tristate
> >>> +	tristate "Qualcomm QMI Helpers"
> >>>  	depends on ARCH_QCOM && NET
> >>>  	help
> >>>  	  Helper library for handling QMI encoded messages.  QMI encoded
> >>>
> >>
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
  2018-09-28 17:21       ` Bjorn Andersson
@ 2018-09-28 17:29         ` Alex Elder
  0 siblings, 0 replies; 10+ messages in thread
From: Alex Elder @ 2018-09-28 17:29 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Niklas Cassel, andy.gross, david.brown, linux-arm-msm, linux-soc,
	linux-kernel

On 09/28/2018 12:21 PM, Bjorn Andersson wrote:
>> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS.  I could
>> change that to select it instead but I still think this entry
>> should be changed.

I was thinking one of two changes:
- Add the prompt string (which I suggested)
- Don't add the prompt, but remove the help and/or add a comment to
  indicate that the lack of prompt is intentional (because it really
  looked like an oversight to me)

I don't really care though; I'll change my code to select it
rather than depend on it.

> Why do you say it needs to change? I tested this by just adding a
> "select QCOM_QMI_HELPERS" in my client drivers.
> 
>> I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig
>> also depends on--rather than selects--QCOM_QMI_HELPERS.
>>
> That's wrong.

Maybe someone else should fix this, but I can do it if you like (and
if that's the case, say so).

					-Alex

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
  2021-10-26 13:42 ` Alex Elder
@ 2021-10-26 18:11   ` Janusz Dziedzic
  0 siblings, 0 replies; 10+ messages in thread
From: Janusz Dziedzic @ 2021-10-26 18:11 UTC (permalink / raw)
  To: Alex Elder; +Cc: LKML, linux-soc

wt., 26 paź 2021 o 15:43 Alex Elder <elder@linaro.org> napisał(a):
>
> On 10/25/21 11:31 AM, Janusz Dziedzic wrote:
> > From: Alex Elder <elder@linaro.org>
> >
> > Add a prompt to the "tristate" attribute in the Kconfig file in
> > which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> > without it.
>
> This was a *long* time ago!
>    https://lore.kernel.org/all/20180427140358.30839-1-elder@linaro.org/
>
> The discussion that followed indicated that the thing that needs
> QCOM_QMI_HELPERS should *select* it rather than *depend on it.
>
> Will this not work for you?
>
This don't work, we can't run select from backports.
Backports drivers - ath11k for this case - build out of the tree as a
separate modules.
Eg. Today we are using kernel 5.10
and backports generated from kernel 5.15.
So our kernel 5.10 don't check CONFIG_ATH11K
This is what I see from our kernel:

Selected by [n]:
ATH11K [=n] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=n] &&
MAC80211 [=n] && HAS_DMA [=y] && CRYPTO_MICHAEL_MIC [=n]

But we build backports/ath11k module which has:
depends on QCOM_QMI_HELPERS


To enable backports/ath11k build we need kernel that have
QCOM_QMI_HELPERS enabled.
Because of that we need this configurable.

BR
Janusz


>                                         -Alex
>
> > We need it in OpenWRT project, when using WiFi backports
> > and build ath11k driver. While ath11k driver depends on
> > QCOM_QMI_HELPERS we need way to enable this option in
> > our kernel.
> >
> > Signed-off-by: Alex Elder <elder@linaro.org>
> > Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com>
> > ---
> >   drivers/soc/qcom/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> > index fe3c486ae32d..16fb8e286015 100644
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
> > @@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS
> >       select QCOM_QMI_HELPERS
> >
> >   config QCOM_QMI_HELPERS
> > -     tristate
> > +     tristate "Qualcomm QMI Helpers"
> >       depends on NET
> >
> >   config QCOM_RMTFS_MEM
> >
>


-- 
Janusz Dziedzic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
  2021-10-25 16:31 Janusz Dziedzic
@ 2021-10-26 13:42 ` Alex Elder
  2021-10-26 18:11   ` Janusz Dziedzic
  0 siblings, 1 reply; 10+ messages in thread
From: Alex Elder @ 2021-10-26 13:42 UTC (permalink / raw)
  To: Janusz Dziedzic, linux-kernel; +Cc: linux-soc

On 10/25/21 11:31 AM, Janusz Dziedzic wrote:
> From: Alex Elder <elder@linaro.org>
> 
> Add a prompt to the "tristate" attribute in the Kconfig file in
> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> without it.

This was a *long* time ago!
   https://lore.kernel.org/all/20180427140358.30839-1-elder@linaro.org/

The discussion that followed indicated that the thing that needs
QCOM_QMI_HELPERS should *select* it rather than *depend on it.

Will this not work for you?

					-Alex

> We need it in OpenWRT project, when using WiFi backports
> and build ath11k driver. While ath11k driver depends on
> QCOM_QMI_HELPERS we need way to enable this option in
> our kernel.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com>
> ---
>   drivers/soc/qcom/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index fe3c486ae32d..16fb8e286015 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS
>   	select QCOM_QMI_HELPERS
>   
>   config QCOM_QMI_HELPERS
> -	tristate
> +	tristate "Qualcomm QMI Helpers"
>   	depends on NET
>   
>   config QCOM_RMTFS_MEM
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
@ 2021-10-25 16:31 Janusz Dziedzic
  2021-10-26 13:42 ` Alex Elder
  0 siblings, 1 reply; 10+ messages in thread
From: Janusz Dziedzic @ 2021-10-25 16:31 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-soc, Alex Elder, Janusz Dziedzic

From: Alex Elder <elder@linaro.org>

Add a prompt to the "tristate" attribute in the Kconfig file in
which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
without it.

We need it in OpenWRT project, when using WiFi backports
and build ath11k driver. While ath11k driver depends on
QCOM_QMI_HELPERS we need way to enable this option in
our kernel.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com>
---
 drivers/soc/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index fe3c486ae32d..16fb8e286015 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS
 	select QCOM_QMI_HELPERS
 
 config QCOM_QMI_HELPERS
-	tristate
+	tristate "Qualcomm QMI Helpers"
 	depends on NET
 
 config QCOM_RMTFS_MEM
-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-10-26 18:11 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 14:03 [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS Alex Elder
2018-09-28 11:41 ` Alex Elder
2018-09-28 12:26   ` Niklas Cassel
2018-09-28 13:23     ` Alex Elder
2018-09-28 14:00       ` Niklas Cassel
2018-09-28 17:21       ` Bjorn Andersson
2018-09-28 17:29         ` Alex Elder
2021-10-25 16:31 Janusz Dziedzic
2021-10-26 13:42 ` Alex Elder
2021-10-26 18:11   ` Janusz Dziedzic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).