LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: Add a new binding for Broadcom V3D 3.x and newer GPUs.
Date: Fri, 27 Apr 2018 14:53:19 -0500	[thread overview]
Message-ID: <20180427195318.s5bzwplylk3uwou4@rob-hp-laptop> (raw)
In-Reply-To: <20180424004610.4637-3-eric@anholt.net>

On Mon, Apr 23, 2018 at 05:46:09PM -0700, Eric Anholt wrote:
> These OpenGL ES GPUs are present in the 7268 and 7278 set top box
> chips.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  .../bindings/display/brcm,bcm-v3d.txt         | 28 +++++++++++++++++++

Does this have display h/w? If not bindings/gpu/ would be more 
appropriate.

>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm-v3d.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-v3d.txt b/Documentation/devicetree/bindings/display/brcm,bcm-v3d.txt
> new file mode 100644
> index 000000000000..1c814714de0e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm-v3d.txt
> @@ -0,0 +1,28 @@
> +Broadcom V3D GPU
> +
> +Only the Broadcom V3D 3.x and newer GPUs are covered by this binding.
> +For V3D 2.x, see brcm,bcm-vc4.txt.
> +
> +Required properties:
> +- compatible:	Should be "brcm,7268-v3d" or "brcm,7278-v3d"
> +- reg:		Physical base addresses and lengths of the register areas
> +- reg-names:	Names for the register areas.  The "hub", "bridge", and "core0"
> +		  register areas are always required.  The "gca" register area
> +		  is required if the GCA cache controller is present.
> +- interrupts:	The interrupt numbers.  The first interrupt is for the hub,
> +		  while the following inerrupts are for the cores.

typo

> +		  See bindings/interrupt-controller/interrupts.txt
> +
> +Optional properties:
> +- clocks:	The core clock the unit runs on
> +
> +v3d {
> +	compatible = "brcm,7268-v3d";
> +	reg = <0xf1204000 0x100>,
> +	      <0xf1200000 0x4000>,
> +	      <0xf1208000 0x4000>,
> +	      <0xf1204100 0x100>;
> +	reg-names = "bridge", "hub", "core0", "gca";
> +	interrupts = <0 78 4>,
> +		     <0 77 4>;
> +};
> -- 
> 2.17.0
> 

  reply	other threads:[~2018-04-27 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  0:46 [PATCH v2 0/3] V3D DRM driver Eric Anholt
2018-04-24  0:46 ` [PATCH v2 1/3] drm: Make the prime vmap/vunmap hooks optional Eric Anholt
2018-04-24 13:13   ` Daniel Vetter
2018-04-24  0:46 ` [PATCH v2 2/3] dt-bindings: Add a new binding for Broadcom V3D 3.x and newer GPUs Eric Anholt
2018-04-27 19:53   ` Rob Herring [this message]
2018-04-24  0:46 ` [PATCH v2 3/3] drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+ Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427195318.s5bzwplylk3uwou4@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --subject='Re: [PATCH v2 2/3] dt-bindings: Add a new binding for Broadcom V3D 3.x and newer GPUs.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).