LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 0/2]
@ 2018-04-26 18:24 Jacopo Mondi
  2018-04-26 18:24 ` [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740 Jacopo Mondi
  2018-04-26 18:24 ` [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0 Jacopo Mondi
  0 siblings, 2 replies; 8+ messages in thread
From: Jacopo Mondi @ 2018-04-26 18:24 UTC (permalink / raw)
  To: geert, horms, robh+dt, mark.rutland
  Cc: Jacopo Mondi, linux-renesas-soc, linux-media, devicetree, linux-kernel

Hello,
   this small series add R-Mobile A1 R8A7740 to the list of CEU supported
SoCs, and adds the CEU node to r8a7740.dtsi.

All the information on CEU clocks, power domains and memory regions have been
deducted from the now-deleted board file:
arch/arm/mach-shmobile/board-armadillo800eva.c

Thanks
   j

v1 -> v2:
- Enlarge the memory range as suggested by Simon
- Fix power domain, as reported by Simon
- s/Enable/[Describe|Add] in commit message

Jacopo Mondi (2):
  dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740
  ARM: dts: r8a7740: Add CEU0

 Documentation/devicetree/bindings/media/renesas,ceu.txt |  7 ++++---
 arch/arm/boot/dts/r8a7740.dtsi                          | 10 ++++++++++
 drivers/media/platform/renesas-ceu.c                    |  1 +
 3 files changed, 15 insertions(+), 3 deletions(-)

--
2.7.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740
  2018-04-26 18:24 [PATCH v2 0/2] Jacopo Mondi
@ 2018-04-26 18:24 ` Jacopo Mondi
  2018-04-27 20:06   ` Rob Herring
  2018-04-30  7:40   ` Simon Horman
  2018-04-26 18:24 ` [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0 Jacopo Mondi
  1 sibling, 2 replies; 8+ messages in thread
From: Jacopo Mondi @ 2018-04-26 18:24 UTC (permalink / raw)
  To: geert, horms, robh+dt, mark.rutland
  Cc: Jacopo Mondi, linux-renesas-soc, linux-media, devicetree, linux-kernel

Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU
unit.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 ++++---
 drivers/media/platform/renesas-ceu.c                    | 1 +
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.txt b/Documentation/devicetree/bindings/media/renesas,ceu.txt
index 3fc66df..8a7a616 100644
--- a/Documentation/devicetree/bindings/media/renesas,ceu.txt
+++ b/Documentation/devicetree/bindings/media/renesas,ceu.txt
@@ -2,14 +2,15 @@ Renesas Capture Engine Unit (CEU)
 ----------------------------------------------
 
 The Capture Engine Unit is the image capture interface found in the Renesas
-SH Mobile and RZ SoCs.
+SH Mobile, R-Mobile and RZ SoCs.
 
 The interface supports a single parallel input with data bus width of 8 or 16
 bits.
 
 Required properties:
-- compatible: Shall be "renesas,r7s72100-ceu" for CEU units found in RZ/A1H
-  and RZ/A1M SoCs.
+- compatible: Shall be one of the following values:
+	"renesas,r7s72100-ceu" for CEU units found in RZ/A1H and RZ/A1M SoCs
+	"renesas,r8a7740-ceu" for CEU units found in R-Mobile A1 R8A7740 SoCs
 - reg: Registers address base and size.
 - interrupts: The interrupt specifier.
 
diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
index 6599dba..c964a56 100644
--- a/drivers/media/platform/renesas-ceu.c
+++ b/drivers/media/platform/renesas-ceu.c
@@ -1545,6 +1545,7 @@ static const struct ceu_data ceu_data_sh4 = {
 #if IS_ENABLED(CONFIG_OF)
 static const struct of_device_id ceu_of_match[] = {
 	{ .compatible = "renesas,r7s72100-ceu", .data = &ceu_data_rz },
+	{ .compatible = "renesas,r8a7740-ceu", .data = &ceu_data_rz },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ceu_of_match);
-- 
2.7.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0
  2018-04-26 18:24 [PATCH v2 0/2] Jacopo Mondi
  2018-04-26 18:24 ` [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740 Jacopo Mondi
@ 2018-04-26 18:24 ` Jacopo Mondi
  2018-05-08 13:33   ` Simon Horman
  2018-05-16  7:40   ` Geert Uytterhoeven
  1 sibling, 2 replies; 8+ messages in thread
From: Jacopo Mondi @ 2018-04-26 18:24 UTC (permalink / raw)
  To: geert, horms, robh+dt, mark.rutland
  Cc: Jacopo Mondi, linux-renesas-soc, linux-media, devicetree, linux-kernel

Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc.

Reported-by: Geert Uytterhoeven <geert@glider.be>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
index afd3bc5..508d934 100644
--- a/arch/arm/boot/dts/r8a7740.dtsi
+++ b/arch/arm/boot/dts/r8a7740.dtsi
@@ -67,6 +67,16 @@
 		power-domains = <&pd_d4>;
 	};
 
+	ceu0: ceu@fe910000 {
+		reg = <0xfe910000 0x3000>;
+		compatible = "renesas,r8a7740-ceu";
+		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp1_clks R8A7740_CLK_CEU20>;
+		clock-names = "ceu20";
+		power-domains = <&pd_a4r>;
+		status = "disabled";
+	};
+
 	cmt1: timer@e6138000 {
 		compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
 		reg = <0xe6138000 0x170>;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740
  2018-04-26 18:24 ` [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740 Jacopo Mondi
@ 2018-04-27 20:06   ` Rob Herring
  2018-04-30  7:40   ` Simon Horman
  1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2018-04-27 20:06 UTC (permalink / raw)
  To: Jacopo Mondi
  Cc: geert, horms, mark.rutland, linux-renesas-soc, linux-media,
	devicetree, linux-kernel

On Thu, Apr 26, 2018 at 08:24:42PM +0200, Jacopo Mondi wrote:
> Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU
> unit.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 ++++---
>  drivers/media/platform/renesas-ceu.c                    | 1 +
>  2 files changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740
  2018-04-26 18:24 ` [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740 Jacopo Mondi
  2018-04-27 20:06   ` Rob Herring
@ 2018-04-30  7:40   ` Simon Horman
  1 sibling, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-04-30  7:40 UTC (permalink / raw)
  To: Jacopo Mondi
  Cc: geert, robh+dt, mark.rutland, linux-renesas-soc, linux-media,
	devicetree, linux-kernel

On Thu, Apr 26, 2018 at 08:24:42PM +0200, Jacopo Mondi wrote:
> Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU
> unit.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 ++++---
>  drivers/media/platform/renesas-ceu.c                    | 1 +
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.txt b/Documentation/devicetree/bindings/media/renesas,ceu.txt
> index 3fc66df..8a7a616 100644
> --- a/Documentation/devicetree/bindings/media/renesas,ceu.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,ceu.txt
> @@ -2,14 +2,15 @@ Renesas Capture Engine Unit (CEU)
>  ----------------------------------------------
>  
>  The Capture Engine Unit is the image capture interface found in the Renesas
> -SH Mobile and RZ SoCs.
> +SH Mobile, R-Mobile and RZ SoCs.
>  
>  The interface supports a single parallel input with data bus width of 8 or 16
>  bits.
>  
>  Required properties:
> -- compatible: Shall be "renesas,r7s72100-ceu" for CEU units found in RZ/A1H
> -  and RZ/A1M SoCs.
> +- compatible: Shall be one of the following values:
> +	"renesas,r7s72100-ceu" for CEU units found in RZ/A1H and RZ/A1M SoCs
> +	"renesas,r8a7740-ceu" for CEU units found in R-Mobile A1 R8A7740 SoCs

Nit: I think you can drop R8A7740 as I believe that by adding it to
R-Mobile A1 you have constructed a tautology (I mean "R-Mobile A1" =
"R8A7740" as far as I know).

>  - reg: Registers address base and size.
>  - interrupts: The interrupt specifier.
>  
> diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
> index 6599dba..c964a56 100644
> --- a/drivers/media/platform/renesas-ceu.c
> +++ b/drivers/media/platform/renesas-ceu.c
> @@ -1545,6 +1545,7 @@ static const struct ceu_data ceu_data_sh4 = {
>  #if IS_ENABLED(CONFIG_OF)
>  static const struct of_device_id ceu_of_match[] = {
>  	{ .compatible = "renesas,r7s72100-ceu", .data = &ceu_data_rz },
> +	{ .compatible = "renesas,r8a7740-ceu", .data = &ceu_data_rz },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, ceu_of_match);
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0
  2018-04-26 18:24 ` [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0 Jacopo Mondi
@ 2018-05-08 13:33   ` Simon Horman
  2018-05-16  7:40   ` Geert Uytterhoeven
  1 sibling, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-05-08 13:33 UTC (permalink / raw)
  To: Jacopo Mondi
  Cc: geert, robh+dt, mark.rutland, linux-renesas-soc, linux-media,
	devicetree, linux-kernel

On Thu, Apr 26, 2018 at 08:24:43PM +0200, Jacopo Mondi wrote:
> Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> 
> Reported-by: Geert Uytterhoeven <geert@glider.be>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Thanks, applied.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0
  2018-04-26 18:24 ` [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0 Jacopo Mondi
  2018-05-08 13:33   ` Simon Horman
@ 2018-05-16  7:40   ` Geert Uytterhoeven
  2018-05-16  8:54     ` Simon Horman
  1 sibling, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2018-05-16  7:40 UTC (permalink / raw)
  To: Jacopo Mondi
  Cc: Simon Horman, Rob Herring, Mark Rutland, Linux-Renesas,
	Linux Media Mailing List,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List

Hi Jacopo,

On Thu, Apr 26, 2018 at 8:24 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
>
> Reported-by: Geert Uytterhoeven <geert@glider.be>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Minor question below.

> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -67,6 +67,16 @@
>                 power-domains = <&pd_d4>;
>         };
>
> +       ceu0: ceu@fe910000 {
> +               reg = <0xfe910000 0x3000>;
> +               compatible = "renesas,r8a7740-ceu";
> +               interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&mstp1_clks R8A7740_CLK_CEU20>;
> +               clock-names = "ceu20";

Why the "clock-names" property? It's not mentioned in the DT bindings, and
may cause issues if the bindings are ever amended.

> +               power-domains = <&pd_a4r>;
> +               status = "disabled";
> +       };
> +

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0
  2018-05-16  7:40   ` Geert Uytterhoeven
@ 2018-05-16  8:54     ` Simon Horman
  0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-05-16  8:54 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Jacopo Mondi, Rob Herring, Mark Rutland, Linux-Renesas,
	Linux Media Mailing List,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List

On Wed, May 16, 2018 at 09:40:09AM +0200, Geert Uytterhoeven wrote:
> Hi Jacopo,
> 
> On Thu, Apr 26, 2018 at 8:24 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> >
> > Reported-by: Geert Uytterhoeven <geert@glider.be>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> 
> Thanks for your patch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Minor question below.
> 
> > --- a/arch/arm/boot/dts/r8a7740.dtsi
> > +++ b/arch/arm/boot/dts/r8a7740.dtsi
> > @@ -67,6 +67,16 @@
> >                 power-domains = <&pd_d4>;
> >         };
> >
> > +       ceu0: ceu@fe910000 {
> > +               reg = <0xfe910000 0x3000>;
> > +               compatible = "renesas,r8a7740-ceu";
> > +               interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> > +               clocks = <&mstp1_clks R8A7740_CLK_CEU20>;
> > +               clock-names = "ceu20";
> 
> Why the "clock-names" property? It's not mentioned in the DT bindings, and
> may cause issues if the bindings are ever amended.

I have dropped that property for now.

> 
> > +               power-domains = <&pd_a4r>;
> > +               status = "disabled";
> > +       };
> > +
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-05-16  8:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 18:24 [PATCH v2 0/2] Jacopo Mondi
2018-04-26 18:24 ` [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740 Jacopo Mondi
2018-04-27 20:06   ` Rob Herring
2018-04-30  7:40   ` Simon Horman
2018-04-26 18:24 ` [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0 Jacopo Mondi
2018-05-08 13:33   ` Simon Horman
2018-05-16  7:40   ` Geert Uytterhoeven
2018-05-16  8:54     ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).