LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Teck Choon Giam <giamteckchoon@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	acme@kernel.org,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: kernel-4.9.94 compile error: 'KMOD_DECOMP_LEN' undeclared
Date: Sat, 28 Apr 2018 07:00:26 +0200	[thread overview]
Message-ID: <20180428050026.GA29422@kroah.com> (raw)
In-Reply-To: <84b1d534-9b9d-ff70-ead6-3f8bb70a4d4b@infradead.org>

On Fri, Apr 27, 2018 at 10:28:27AM -0700, Randy Dunlap wrote:
> [adding some Cc:]
> 
> On 04/14/2018 02:41 AM, Teck Choon Giam wrote:
> > Hi,
> > 
> > Compile linux-4.9.94 will have error related to KMOD_DECOMP_LEN
> > undeclared.  Searching string related to KMOD_DECOMP_LEN in
> > linux-4.9.94 and linux-4.15.17 sources as below:
> > 
> > <mock-chroot>sh-4.2# grep -r KMOD_DECOMP_LEN ./linux-4.15.17
> > ./linux-4.15.17/tools/perf/tests/code-reading.c: char
> > decomp_name[KMOD_DECOMP_LEN];
> > ./linux-4.15.17/tools/perf/util/dso.h:#define KMOD_DECOMP_LEN
> > sizeof(KMOD_DECOMP_NAME)
> > ./linux-4.15.17/tools/perf/util/annotate.c: char tmp[KMOD_DECOMP_LEN];
> > ./linux-4.15.17/tools/perf/util/dso.c: char newpath[KMOD_DECOMP_LEN];
> > sh-4.2# grep -r KMOD_DECOMP_LEN ./linux-4.9.94
> > ./linux-4.9.94/tools/perf/tests/code-reading.c: char
> > decomp_name[KMOD_DECOMP_LEN];
> > ./linux-4.9.94/tools/perf/util/dso.c: char newpath[KMOD_DECOMP_LEN];
> > 
> > So I guess for linux-4.9.94 has not define KMOD_DECOMP_LEN in
> > tools/perf/util/dso.h?
> 
> 
> 4.9.9[456] lack:
> #define KMOD_DECOMP_NAME  "/tmp/perf-kmod-XXXXXX"
> #define KMOD_DECOMP_LEN   sizeof(KMOD_DECOMP_NAME)
> 
> 
> However, the commit that added those macros does not apply cleanly to 4.9.96.
> 
> commit 42b3fa670825983fc8bd0ac7b80cc84ae3abb75b
> Author: Namhyung Kim <namhyung@kernel.org>
> Date:   Thu Jun 8 16:31:03 2017 +0900
> 
>     perf tools: Introduce dso__decompress_kmodule_{fd,path}

This should now be fixed in the latest 4.9.y -rc release, right?

If not, please let me know as I though I resolved this problem there...

thanks,

greg k-h

  reply	other threads:[~2018-04-28  5:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14  9:41 Teck Choon Giam
2018-04-14 17:29 ` Akemi Yagi
2018-04-20  9:29 ` Teck Choon Giam
2018-04-27 17:28 ` Randy Dunlap
2018-04-28  5:00   ` Greg Kroah-Hartman [this message]
2018-04-28  6:09     ` Randy Dunlap
2018-04-28  8:11       ` Greg Kroah-Hartman
2018-04-28 11:54         ` Teck Choon Giam
2018-04-28 11:58           ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180428050026.GA29422@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=giamteckchoon@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --subject='Re: kernel-4.9.94 compile error: '\''KMOD_DECOMP_LEN'\'' undeclared' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).