LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: David Engraf <david.engraf@sysgo.com>
Cc: ludovic.desroches@microchip.com, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: at91: Read all available bytes at once
Date: Sat, 28 Apr 2018 14:38:38 +0200	[thread overview]
Message-ID: <20180428123838.abxiht7k4egv7iel@ninjato> (raw)
In-Reply-To: <20180426095314.12758-1-david.engraf@sysgo.com>

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

On Thu, Apr 26, 2018 at 11:53:14AM +0200, David Engraf wrote:
> With FIFO enabled it is possible to read multiple bytes
> at once in the interrupt handler as long as RXRDY is
> set. This may also reduce the number of interrupts.
> 
> This patch polls RXRDY and reads all available bytes at
> once.
> 
> Signed-off-by: David Engraf <david.engraf@sysgo.com>

checkpatch said twice:

WARNING: line over 80 characters

While I am not super-strict with this limit, it makes sense here IMO.
The comment stays readable, and we don't even lose a line.

Fixed it this time for you.

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-04-28 12:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 12:40 [PATCH] " David Engraf
2018-04-25 15:08 ` Ludovic Desroches
2018-04-25 15:43   ` David Engraf
2018-04-26  8:25     ` Ludovic Desroches
2018-04-26  9:53       ` [PATCH v2] " David Engraf
2018-04-26 12:30         ` Ludovic Desroches
2018-04-28 12:38         ` Wolfram Sang [this message]
2018-04-30  6:11           ` David Engraf
2018-04-26  5:52   ` [PATCH] " David Engraf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180428123838.abxiht7k4egv7iel@ninjato \
    --to=wsa@the-dreams.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=david.engraf@sysgo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --subject='Re: [PATCH v2] i2c: at91: Read all available bytes at once' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).