LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: add myself as maintainer of AFFS
@ 2018-04-28 17:05 David Sterba
  2018-04-28 17:33 ` Linus Torvalds
  0 siblings, 1 reply; 3+ messages in thread
From: David Sterba @ 2018-04-28 17:05 UTC (permalink / raw)
  To: torvalds
  Cc: David Sterba, linux-kernel, Martin Steigerwald,
	John Paul Adrian Glaubitz

The AFFS filesystem is still in use by m68k community (Link #2), but as
there was no code activity and no maintainer, the filesystem appeared on
the list of candidates for staging/removal (Link #1).

I volunteer to act as a maintainer of AFFS to collect any fixes that
might show up and to guard fs/affs/ against another spring cleaning.

Link: https://lkml.kernel.org/r/20180425154602.GA8546@bombadil.infradead.org
Link: https://lkml.kernel.org/r/1613268.lKBQxPXt8J@merkaba
CC: Martin Steigerwald <martin@lichtvoll.de>
CC: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: David Sterba <dsterba@suse.com>
---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index dd66ae9a847e..9d268895bd56 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -564,8 +564,10 @@ S:	Maintained
 F:	drivers/media/dvb-frontends/af9033*
 
 AFFS FILE SYSTEM
+M:	David Sterba <dsterba@suse.com>
 L:	linux-fsdevel@vger.kernel.org
-S:	Orphan
+S:	Odd Fixes
 F:	Documentation/filesystems/affs.txt
 F:	fs/affs/
 
-- 
2.16.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MAINTAINERS: add myself as maintainer of AFFS
  2018-04-28 17:05 [PATCH] MAINTAINERS: add myself as maintainer of AFFS David Sterba
@ 2018-04-28 17:33 ` Linus Torvalds
  2018-04-28 17:58   ` David Sterba
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2018-04-28 17:33 UTC (permalink / raw)
  To: David Sterba
  Cc: Linux Kernel Mailing List, Martin Steigerwald, John Paul Adrian Glaubitz

On Sat, Apr 28, 2018 at 10:07 AM David Sterba <dsterba@suse.com> wrote:

> I volunteer to act as a maintainer of AFFS to collect any fixes that
> might show up and to guard fs/affs/ against another spring cleaning.

Hmm. Please be more careful.

> @@ -564,8 +564,10 @@ S: Maintained

The above says it adds two lines (8 -> 10), but the actual patch itself
only adds one, and modifies another:

> +M:     David Sterba <dsterba@suse.com>
> -S:     Orphan
> +S:     Odd Fixes

I'm used to editing patches for things like this, because I have years and
years of just hand-editing patches I didn't like for some reason, but it
looks like you tried to edit a patch without knowing all the rules for how
unified patches work.

So please don't edit patches by hand.  It's a skill nobody should have.

Anyway, I fixed the patch and applied it, but let's not make a habit of it.

               Linus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MAINTAINERS: add myself as maintainer of AFFS
  2018-04-28 17:33 ` Linus Torvalds
@ 2018-04-28 17:58   ` David Sterba
  0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2018-04-28 17:58 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: David Sterba, Linux Kernel Mailing List, Martin Steigerwald,
	John Paul Adrian Glaubitz

On Sat, Apr 28, 2018 at 05:33:57PM +0000, Linus Torvalds wrote:
> On Sat, Apr 28, 2018 at 10:07 AM David Sterba <dsterba@suse.com> wrote:
> 
> > I volunteer to act as a maintainer of AFFS to collect any fixes that
> > might show up and to guard fs/affs/ against another spring cleaning.
> 
> Hmm. Please be more careful.
> 
> > @@ -564,8 +564,10 @@ S: Maintained
> 
> The above says it adds two lines (8 -> 10), but the actual patch itself
> only adds one, and modifies another:
> 
> > +M:     David Sterba <dsterba@suse.com>
> > -S:     Orphan
> > +S:     Odd Fixes
> 
> I'm used to editing patches for things like this, because I have years and
> years of just hand-editing patches I didn't like for some reason, but it
> looks like you tried to edit a patch without knowing all the rules for how
> unified patches work.
> 
> So please don't edit patches by hand.  It's a skill nobody should have.
> 
> Anyway, I fixed the patch and applied it, but let's not make a habit of it.

Sorry, it was a last minute change. There was a T: line with a git tree
reference, but this looked odd and I deleted it, but did not realize the
patch would not apply. Too excited to send it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-28 18:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-28 17:05 [PATCH] MAINTAINERS: add myself as maintainer of AFFS David Sterba
2018-04-28 17:33 ` Linus Torvalds
2018-04-28 17:58   ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).