From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751212AbeD1SBa (ORCPT ); Sat, 28 Apr 2018 14:01:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:44436 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbeD1SB3 (ORCPT ); Sat, 28 Apr 2018 14:01:29 -0400 Date: Sat, 28 Apr 2018 19:58:53 +0200 From: David Sterba To: Linus Torvalds Cc: David Sterba , Linux Kernel Mailing List , Martin Steigerwald , John Paul Adrian Glaubitz Subject: Re: [PATCH] MAINTAINERS: add myself as maintainer of AFFS Message-ID: <20180428175853.GM21272@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Linus Torvalds , David Sterba , Linux Kernel Mailing List , Martin Steigerwald , John Paul Adrian Glaubitz References: <20180428170504.16031-1-dsterba@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 28, 2018 at 05:33:57PM +0000, Linus Torvalds wrote: > On Sat, Apr 28, 2018 at 10:07 AM David Sterba wrote: > > > I volunteer to act as a maintainer of AFFS to collect any fixes that > > might show up and to guard fs/affs/ against another spring cleaning. > > Hmm. Please be more careful. > > > @@ -564,8 +564,10 @@ S: Maintained > > The above says it adds two lines (8 -> 10), but the actual patch itself > only adds one, and modifies another: > > > +M: David Sterba > > -S: Orphan > > +S: Odd Fixes > > I'm used to editing patches for things like this, because I have years and > years of just hand-editing patches I didn't like for some reason, but it > looks like you tried to edit a patch without knowing all the rules for how > unified patches work. > > So please don't edit patches by hand. It's a skill nobody should have. > > Anyway, I fixed the patch and applied it, but let's not make a habit of it. Sorry, it was a last minute change. There was a T: line with a git tree reference, but this looked odd and I deleted it, but did not realize the patch would not apply. Too excited to send it.