LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-28 19:57 Moritz Fischer
  2018-05-02  4:37 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Moritz Fischer @ 2018-04-28 19:57 UTC (permalink / raw)
  To: linux-kernel; +Cc: dmaengine, dan.j.williams, vinod.koul, lars, Moritz Fischer

Request IRQ with IRQF_SHARED flag to enable setups with multiple
instances of the core sharing a single IRQ line.
This works out since the IRQ handler already checks if there is
an actual IRQ pending and returns IRQ_NONE otherwise.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---

Changes from v2:
- Reworded commit message

Changes from v1:
- Added Lars' Acked-by
- Dropped patch [1/2] and changed accordingly

---
 drivers/dma/dma-axi-dmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 2419fe524daa..15b2453d2647 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unregister_device;
 
-	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
+	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
 		dev_name(&pdev->dev), dmac);
 	if (ret)
 		goto err_unregister_of;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-28 19:57 [PATCH v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Moritz Fischer
@ 2018-05-02  4:37 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2018-05-02  4:37 UTC (permalink / raw)
  To: Moritz Fischer; +Cc: linux-kernel, dmaengine, dan.j.williams, lars

On Sat, Apr 28, 2018 at 12:57:54PM -0700, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag to enable setups with multiple
> instances of the core sharing a single IRQ line.
> This works out since the IRQ handler already checks if there is
> an actual IRQ pending and returns IRQ_NONE otherwise.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-02  4:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-28 19:57 [PATCH v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Moritz Fischer
2018-05-02  4:37 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).