LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michal Hocko <email@example.com>
To: David Hildenbrand <firstname.lastname@example.org>
Cc: Matthew Wilcox <email@example.com>,
Vlastimil Babka <firstname.lastname@example.org>,
email@example.com, Steven Rostedt <firstname.lastname@example.org>,
Ingo Molnar <email@example.com>,
Andrew Morton <firstname.lastname@example.org>,
Huang Ying <email@example.com>,
Greg Kroah-Hartman <firstname.lastname@example.org>,
Pavel Tatashin <email@example.com>,
Miles Chen <firstname.lastname@example.org>,
Mel Gorman <email@example.com>,
Rik van Riel <firstname.lastname@example.org>, James Hogan <email@example.com>,
"Levin, Alexander (Sasha Levin)" <firstname.lastname@example.org>,
open list <email@example.com>
Subject: Re: [PATCH RFC 2/8] mm: introduce PG_offline
Date: Sun, 29 Apr 2018 23:08:50 +0200 [thread overview]
Message-ID: <20180429210850.GB26305@dhcp22.suse.cz> (raw)
On Sun 22-04-18 17:13:52, David Hildenbrand wrote:
> On 22.04.2018 16:02, Matthew Wilcox wrote:
> > On Sun, Apr 22, 2018 at 10:17:31AM +0200, David Hildenbrand wrote:
> >> On 22.04.2018 05:01, Matthew Wilcox wrote:
> >>> On Sat, Apr 21, 2018 at 06:52:18PM +0200, Vlastimil Babka wrote:
> >>>> Sounds like your newly introduced "page types" could be useful here? I
> >>>> don't suppose those offline pages would be using mapcount which is
> >>>> aliased there?
> >>> Oh, that's a good point! Yes, this is a perfect use for page_type.
> >>> We have something like twenty bits available there.
> >>> Now you've got me thinking that we can move PG_hwpoison and PG_reserved
> >>> to be page_type flags too. That'll take us from 23 to 21 bits (on 32-bit,
> >>> with PG_UNCACHED)
> >> Some things to clarify here. I modified the current RFC to also allow
> >> PG_offline on allocated (ballooned) pages (e.g. virtio-balloon).
> >> kdump based dump tools can then easily identify which pages are not to
> >> be dumped (either because the content is invalid or not accessible).
> >> I previously stated that ballooned pages would be marked as PG_reserved,
> >> which is not true (at least not for virtio-balloon). However this allows
> >> me to detect if all pages in a section are offline by looking at
> >> (PG_reserved && PG_offline). So I can actually tell if a page is marked
> >> as offline and allocated or really offline.
> >> 1. The location (not the number!) of PG_hwpoison is basically ABI and
> >> cannot be changed. Moving it around will most probably break dump tools.
> >> (see kernel/crash_core.c)
> > It's not ABI. It already changed after 4.9 when PG_waiters was introduced
> > by commit 62906027091f.
> It is, please have a look at the file I pointed you to.
> We export the *value* of PG_hwpoison in the ELF file, therefore the
> *value* can change, but the *location* (page_flags, mapcount, whatever)
> must not change. Or am I missing something here? I don't think we can
> move PG_hwpoison that easily.
> Also, I can read "For pages that are never mapped to userspace,
> page->mapcount may be used for storing extra information about page
> type" - is that true for PG_hwpoison/PG_reserved? I am skeptical.
> And we need something similar for PG_offline, because it will become
> ABI. (I can see that PAGE_BUDDY_MAPCOUNT_VALUE is also exported in an
> ELF file, so maybe a new page type might work for marking a page offline
> - but I have to look at the details first tomorrow)
Wait wait wait. Who is relying on this? Kdump? Page flags have always
been an internal implementation detail and _nobody_ outside of the
kernel should ever rely on the specific value. Well, kdump has been
cheating but that is because kdump is inherently tight to a specific
kernel implementation but that doesn't make it a stable ABI IMHO.
Restricting the kernel internals because of a debugging tool would be
next prev parent reply other threads:[~2018-04-29 21:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <firstname.lastname@example.org>
2018-04-13 13:16 ` [PATCH RFC 1/8] mm/memory_hotplug: Revert "mm/memory_hotplug: optimize memory hotplug" David Hildenbrand
2018-04-13 13:16 ` [PATCH RFC 2/8] mm: introduce PG_offline David Hildenbrand
2018-04-13 13:40 ` Michal Hocko
2018-04-13 13:46 ` David Hildenbrand
2018-04-17 11:50 ` David Hildenbrand
2018-04-13 17:11 ` Matthew Wilcox
2018-04-16 8:31 ` David Hildenbrand
2018-04-21 16:52 ` Vlastimil Babka
2018-04-22 3:01 ` Matthew Wilcox
2018-04-22 8:17 ` David Hildenbrand
2018-04-22 14:02 ` Matthew Wilcox
2018-04-22 15:13 ` David Hildenbrand
2018-04-29 21:08 ` Michal Hocko [this message]
2018-04-30 6:31 ` David Hildenbrand
2018-04-20 7:30 ` David Hildenbrand
2018-04-13 13:16 ` [PATCH RFC 3/8] mm: use PG_offline in online/offlining code David Hildenbrand
2018-04-13 13:31 ` [PATCH RFC 4/8] kdump: expose PG_offline David Hildenbrand
2018-04-13 13:33 ` [PATCH RFC 5/8] mm: only mark section offline when all pages are offline David Hildenbrand
2018-04-13 13:33 ` [PATCH RFC 6/8] mm: offline_pages() is also limited by MAX_ORDER David Hildenbrand
2018-04-13 13:33 ` [PATCH RFC 7/8] mm: allow to control onlining/offlining of memory by a driver David Hildenbrand
2018-04-13 15:59 ` Michal Hocko
2018-04-13 16:32 ` David Hildenbrand
2018-04-13 13:33 ` [PATCH RFC 8/8] mm: export more functions used to online/offline memory David Hildenbrand
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH RFC 2/8] mm: introduce PG_offline' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).