LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: Signed-off-by missing for commit in the net tree
@ 2018-04-29 21:18 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2018-04-29 21:18 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Israel Rukshin, Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hi all,

Commit

  6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2022-04-25 21:53 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2022-04-25 21:53 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Rongguang Wei, Pablo Neira Ayuso, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi all,

Commit

  b9b1e0da5800 ("netfilter: flowtable: Remove the empty file")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2021-11-29 20:32 Stephen Rothwell
@ 2021-11-29 20:42 ` Jason A. Donenfeld
  0 siblings, 0 replies; 33+ messages in thread
From: Jason A. Donenfeld @ 2021-11-29 20:42 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, msizanoen1, Linux Kernel Mailing List,
	Linux Next Mailing List, Greg Kroah-Hartman, Jakub Kicinski

Hi Stephen,

This is known. Please see the below-the-break comment in the original
patch submission:

https://lore.kernel.org/netdev/20211123124832.15419-1-Jason@zx2c4.com/

> The original author of this commit and commit message is anonymous and
> is therefore unable to sign off on it. Greg suggested that I do the sign
> off, extracting it from the bugzilla entry above, and post it properly.
> The patch "seems to work" on first glance, but I haven't looked deeply
> at it yet and therefore it doesn't have my Reviewed-by, even though I'm
> submitting this patch on the author's behalf. And it should probably get
> a good look from the v6 fib folks. The original author should be on this
> thread to address issues that come off, and I'll shephard additional
> versions that he has.

Jason

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2021-11-29 20:32 Stephen Rothwell
  2021-11-29 20:42 ` Jason A. Donenfeld
  0 siblings, 1 reply; 33+ messages in thread
From: Stephen Rothwell @ 2021-11-29 20:32 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: msizanoen1, Jason A. Donenfeld, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi all,

Commit

  cdef485217d3 ("ipv6: fix memory leak in fib6_rule_suppress")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2021-05-19 21:46 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2021-05-19 21:46 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Saeed Mahameed, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,

Commit

  6ff51ab8aa8f ("net/mlx5: Set term table as an unmanaged flow table")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2021-05-05 22:14 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2021-05-05 22:14 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Maciej Żenczykowski, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

Hi all,

Commit

  2c16db6c92b0 ("net: fix nla_strcmp to handle more then one trailing null character")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2020-09-20 19:50 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2020-09-20 19:50 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Simon Wunderlich, Sven Eckelmann, Linus Lüssing

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

Hi all,

Commit

  097930e85f90 ("batman-adv: bla: fix type misuse for backbone_gw hash indexing")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2020-05-31 17:57 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2020-05-31 17:57 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

Hi all,

Commit

  02c71b144c81 ("l2tp: do not use inet_hash()/inet_unhash()")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-12-07  7:18 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2019-12-07  7:18 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jouni Hogander

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

Hi all,

Commit

  e0b60903b434 ("net-sysfs: Call dev_hold always in netdev_queue_add_kobject")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-11-17 20:11 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2019-11-17 20:11 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

Hi all,

Commit

  34e59836565e ("net/mlx4_en: fix mlx4 ethtool -N insertion")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2019-11-13 20:21 Stephen Rothwell
@ 2019-11-14  8:25 ` Marc Kleine-Budde
  0 siblings, 0 replies; 33+ messages in thread
From: Marc Kleine-Budde @ 2019-11-14  8:25 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1.1: Type: text/plain, Size: 1527 bytes --]

On 11/13/19 9:21 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   4a15d574e68a ("can: j1939: warn if resources are still linked on destroy")
>   ddeeb7d4822e ("can: j1939: j1939_can_recv(): add priv refcounting")
>   8d7a5f000e23 ("can: j1939: transport: j1939_cancel_active_session(): use hrtimer_try_to_cancel() instead of hrtimer_cancel()")
>   62ebce1dc1fa ("can: j1939: make sure socket is held as long as session exists")
>   d966635b384b ("can: j1939: transport: make sure the aborted session will be deactivated only once")
>   fd81ebfe7975 ("can: j1939: socket: rework socket locking for j1939_sk_release() and j1939_sk_sendmsg()")
>   c48c8c1e2e81 ("can: j1939: main: j1939_ndev_to_priv(): avoid crash if can_ml_priv is NULL")
>   25fe97cb7620 ("can: j1939: move j1939_priv_put() into sk_destruct callback")
>   975987e7015b ("can: af_can: export can_sock_destruct()")
> 
> are missing a Signed-off-by from their committer.

Ouch! Sorry my fault.

> Dave, since your trees are immutable, you are really going to have to
> do some premerge checking for these ... I have attached the scripts I
> use.  Others have some git hooks which do something similar.

I'll integrate this script into mine.

regard.
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-11-13 20:21 Stephen Rothwell
  2019-11-14  8:25 ` Marc Kleine-Budde
  0 siblings, 1 reply; 33+ messages in thread
From: Stephen Rothwell @ 2019-11-13 20:21 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Marc Kleine-Budde


[-- Attachment #1.1: Type: text/plain, Size: 1123 bytes --]

Hi all,

Commits

  4a15d574e68a ("can: j1939: warn if resources are still linked on destroy")
  ddeeb7d4822e ("can: j1939: j1939_can_recv(): add priv refcounting")
  8d7a5f000e23 ("can: j1939: transport: j1939_cancel_active_session(): use hrtimer_try_to_cancel() instead of hrtimer_cancel()")
  62ebce1dc1fa ("can: j1939: make sure socket is held as long as session exists")
  d966635b384b ("can: j1939: transport: make sure the aborted session will be deactivated only once")
  fd81ebfe7975 ("can: j1939: socket: rework socket locking for j1939_sk_release() and j1939_sk_sendmsg()")
  c48c8c1e2e81 ("can: j1939: main: j1939_ndev_to_priv(): avoid crash if can_ml_priv is NULL")
  25fe97cb7620 ("can: j1939: move j1939_priv_put() into sk_destruct callback")
  975987e7015b ("can: af_can: export can_sock_destruct()")

are missing a Signed-off-by from their committer.

Dave, since your trees are immutable, you are really going to have to
do some premerge checking for these ... I have attached the scripts I
use.  Others have some git hooks which do something similar.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_commits --]
[-- Type: application/x-shellscript, Size: 1694 bytes --]

[-- Attachment #1.3: check_fixes --]
[-- Type: application/x-shellscript, Size: 4344 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-10-15 20:36 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2019-10-15 20:36 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Mahesh Bandewar

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

Hi all,

Commit

  b0818f80c8c1 ("blackhole_netdev: fix syzkaller reported issue")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2019-08-05 21:38 Stephen Rothwell
@ 2019-08-05 21:43 ` David Miller
  0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2019-08-05 21:43 UTC (permalink / raw)
  To: sfr; +Cc: netdev, linux-next, linux-kernel

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 6 Aug 2019 07:38:25 +1000

> Commit
> 
>   c3953a3c2d31 ("NFC: nfcmrvl: fix gpio-handling regression")
> 
> is missing a Signed-off-by from its committer.

That has to be the first time that's ever happened to me :-)

And indeed as I check my command line history I forgot the --signoff
command line option.


^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-08-05 21:38 Stephen Rothwell
  2019-08-05 21:43 ` David Miller
  0 siblings, 1 reply; 33+ messages in thread
From: Stephen Rothwell @ 2019-08-05 21:38 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

Hi all,

Commit

  c3953a3c2d31 ("NFC: nfcmrvl: fix gpio-handling regression")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2019-04-13  8:30 Stephen Rothwell
@ 2019-04-13 10:34 ` David Howells
  0 siblings, 0 replies; 33+ messages in thread
From: David Howells @ 2019-04-13 10:34 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: dhowells, David Miller, Networking, Linux Next Mailing List,
	Linux Kernel Mailing List, Marc Dionne

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Commit
> 
>   4611da30d679 ("rxrpc: Make rxrpc_kernel_check_life() indicate if call completed")
> 
> is missing a Signed-off-by from its author.

I should have reassigned authorship to myself since I rewrote the patch.

David

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-04-13  8:30 Stephen Rothwell
  2019-04-13 10:34 ` David Howells
  0 siblings, 1 reply; 33+ messages in thread
From: Stephen Rothwell @ 2019-04-13  8:30 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Marc Dionne,
	David Howells

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

Hi all,

Commit

  4611da30d679 ("rxrpc: Make rxrpc_kernel_check_life() indicate if call completed")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-03-19  5:21 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2019-03-19  5:21 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zhiqiang Liu,
	Suanming.Mou

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

Hi all,

Commit

  cc4807bb6092 ("vxlan: Don't call gro_cells_destroy() before device is unregistered")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-03-18  4:50 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2019-03-18  4:50 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

Hi all,

Commit

  65e9a6d25deb ("networking: fix snmp_counter.rst Doc. Warnings")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2019-01-11  6:27   ` Frank Wunderlich
@ 2019-01-11 13:58     ` Andrew Lunn
  0 siblings, 0 replies; 33+ messages in thread
From: Andrew Lunn @ 2019-01-11 13:58 UTC (permalink / raw)
  To: Frank Wunderlich
  Cc: Heiner Kallweit, Stephen Rothwell, David Miller, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List

On Fri, Jan 11, 2019 at 07:27:40AM +0100, Frank Wunderlich wrote:
> Should i make v3 with all tags or me as author?

Hi Franks

The code is already merged. So the patch cannot be updated.

Heiner did the right thing, posting to the list. So it is document,
even if it is not in the ideal location. If anybody ever needed to
check, with a bit of detective work they should find the needed SOB.

       Andrew

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2019-01-11  6:10 ` Heiner Kallweit
@ 2019-01-11  6:27   ` Frank Wunderlich
  2019-01-11 13:58     ` Andrew Lunn
  0 siblings, 1 reply; 33+ messages in thread
From: Frank Wunderlich @ 2019-01-11  6:27 UTC (permalink / raw)
  To: Heiner Kallweit, Stephen Rothwell, David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

Should i make v3 with all tags or me as author?

Regards Frank

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2019-01-11  3:48 Stephen Rothwell
@ 2019-01-11  6:10 ` Heiner Kallweit
  2019-01-11  6:27   ` Frank Wunderlich
  0 siblings, 1 reply; 33+ messages in thread
From: Heiner Kallweit @ 2019-01-11  6:10 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking, Frank Wunderlich
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 11.01.2019 04:48, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   b19bce0335e2 ("net: ethernet: mediatek: fix warning in phy_start_aneg")
> 
> is missing a Signed-off-by from its author.
> 
I suggested the changes and Frank prepared the patch with me as author.
Therefore:

Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2019-01-11  3:48 Stephen Rothwell
  2019-01-11  6:10 ` Heiner Kallweit
  0 siblings, 1 reply; 33+ messages in thread
From: Stephen Rothwell @ 2019-01-11  3:48 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Heiner Kallweit, Frank Wunderlich

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,

Commit

  b19bce0335e2 ("net: ethernet: mediatek: fix warning in phy_start_aneg")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2018-11-21  5:04 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2018-11-21  5:04 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi all,

Commit

  f2cbd4852820 ("net/sched: act_police: fix race condition on state variables")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2018-11-20  8:25 ` Xin Long
@ 2018-11-20 17:17   ` David Miller
  0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2018-11-20 17:17 UTC (permalink / raw)
  To: lucien.xin; +Cc: sfr, netdev, linux-next, linux-kernel

From: Xin Long <lucien.xin@gmail.com>
Date: Tue, 20 Nov 2018 17:25:30 +0900

> Do I need to do something for this one now?

No, there is nothing you can do about it :-)

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2018-11-20  5:15 Stephen Rothwell
@ 2018-11-20  8:25 ` Xin Long
  2018-11-20 17:17   ` David Miller
  0 siblings, 1 reply; 33+ messages in thread
From: Xin Long @ 2018-11-20  8:25 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: davem, network dev, Linux-Next Mailing List, LKML

On Tue, Nov 20, 2018 at 2:15 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commit
>
>   69fec325a643 ("Revert "sctp: remove sctp_transport_pmtu_check"")
>
> is missing a Signed-off-by from its author.
Hi, Stephen, sorry about this.

David has reminded me, and I will be careful next time.

Do I need to do something for this one now?

Thanks.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2018-11-20  5:15 Stephen Rothwell
  2018-11-20  8:25 ` Xin Long
  0 siblings, 1 reply; 33+ messages in thread
From: Stephen Rothwell @ 2018-11-20  5:15 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Xin Long

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Hi all,

Commit

  69fec325a643 ("Revert "sctp: remove sctp_transport_pmtu_check"")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2018-07-04 21:49 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2018-07-04 21:49 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

Hi all,

Commit

  33bd5ac54dc4 ("net/ipv6: Revert attempt to simplify route replace and append")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the net tree
  2018-05-10 21:17 Stephen Rothwell
@ 2018-05-11  1:30 ` Hangbin Liu
  0 siblings, 0 replies; 33+ messages in thread
From: Hangbin Liu @ 2018-05-11  1:30 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: David Miller, Networking, Linux-Next Mailing List,
	Linux Kernel Mailing List

On Fri, May 11, 2018 at 07:17:16AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   0e8411e426e2 ("ipv4: reset fnhe_mtu_locked after cache route flushed")
> 
> is missing a Signed-off-by from its author.

Opps, My bad.

> After route cache is flushed via ipv4_sysctl_rtcache_flush(), we forget
> to reset fnhe_mtu_locked in rt_bind_exception(). When pmtu is updated
> in __ip_rt_update_pmtu(), it will return directly since the pmtu is
> still locked. e.g.
>
> + ip netns exec client ping 10.10.1.1 -c 1 -s 1400 -M do
> PING 10.10.1.1 (10.10.1.1) 1400(1428) bytes of data.
> From 10.10.0.254 icmp_seq=1 Frag needed and DF set (mtu = 0)
>
> --- 10.10.1.1 ping statistics ---
> 1 packets transmitted, 0 received, +1 errors, 100% packet loss, time 0ms

I shouldn't add comments with the '---' lines. David reminded me before. But
I didn't realise it when pasted the ping logs. Another lesson learned...

Thanks Stephen.

Regards
Hangbin

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2018-05-10 21:17 Stephen Rothwell
  2018-05-11  1:30 ` Hangbin Liu
  0 siblings, 1 reply; 33+ messages in thread
From: Stephen Rothwell @ 2018-05-10 21:17 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Hangbin Liu

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Hi all,

Commit

  0e8411e426e2 ("ipv4: reset fnhe_mtu_locked after cache route flushed")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2018-02-08 22:18 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2018-02-08 22:18 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Hoang Le, Jon Maloy

Hi all,

Commit

  55b3280d1e47 ("tipc: fix skb truesize/datasize ratio control")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2018-02-08  3:27 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2018-02-08  3:27 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Md. Islam

Hi all,

Commit

  043e337f555e ("sch_netem: Bug fixing in calculating Netem interval")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 33+ messages in thread

* linux-next: Signed-off-by missing for commit in the net tree
@ 2017-09-19  4:43 Stephen Rothwell
  0 siblings, 0 replies; 33+ messages in thread
From: Stephen Rothwell @ 2017-09-19  4:43 UTC (permalink / raw)
  To: David Miller, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Eric Dumazet,
	Ville Syrjälä

Hi all,

Commit

  129c6cda2de2 ("8139too: revisit napi_complete_done() usage")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 33+ messages in thread

end of thread, other threads:[~2022-04-25 22:23 UTC | newest]

Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-29 21:18 linux-next: Signed-off-by missing for commit in the net tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2022-04-25 21:53 Stephen Rothwell
2021-11-29 20:32 Stephen Rothwell
2021-11-29 20:42 ` Jason A. Donenfeld
2021-05-19 21:46 Stephen Rothwell
2021-05-05 22:14 Stephen Rothwell
2020-09-20 19:50 Stephen Rothwell
2020-05-31 17:57 Stephen Rothwell
2019-12-07  7:18 Stephen Rothwell
2019-11-17 20:11 Stephen Rothwell
2019-11-13 20:21 Stephen Rothwell
2019-11-14  8:25 ` Marc Kleine-Budde
2019-10-15 20:36 Stephen Rothwell
2019-08-05 21:38 Stephen Rothwell
2019-08-05 21:43 ` David Miller
2019-04-13  8:30 Stephen Rothwell
2019-04-13 10:34 ` David Howells
2019-03-19  5:21 Stephen Rothwell
2019-03-18  4:50 Stephen Rothwell
2019-01-11  3:48 Stephen Rothwell
2019-01-11  6:10 ` Heiner Kallweit
2019-01-11  6:27   ` Frank Wunderlich
2019-01-11 13:58     ` Andrew Lunn
2018-11-21  5:04 Stephen Rothwell
2018-11-20  5:15 Stephen Rothwell
2018-11-20  8:25 ` Xin Long
2018-11-20 17:17   ` David Miller
2018-07-04 21:49 Stephen Rothwell
2018-05-10 21:17 Stephen Rothwell
2018-05-11  1:30 ` Hangbin Liu
2018-02-08 22:18 Stephen Rothwell
2018-02-08  3:27 Stephen Rothwell
2017-09-19  4:43 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).