LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 12/12] gpio: xlp: Use of_device_get_match_data()
Date: Mon, 30 Apr 2018 09:38:19 +0200	[thread overview]
Message-ID: <20180430073819.31827-12-thierry.reding@gmail.com> (raw)
In-Reply-To: <20180430073819.31827-1-thierry.reding@gmail.com>

From: Thierry Reding <treding@nvidia.com>

Use of_device_get_match_data() instead of open-coding it.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpio/gpio-xlp.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-xlp.c b/drivers/gpio/gpio-xlp.c
index e74bd43a6974..8e4275eaa7d7 100644
--- a/drivers/gpio/gpio-xlp.c
+++ b/drivers/gpio/gpio-xlp.c
@@ -322,14 +322,7 @@ static int xlp_gpio_probe(struct platform_device *pdev)
 		return irq;
 
 	if (pdev->dev.of_node) {
-		const struct of_device_id *of_id;
-
-		of_id = of_match_device(xlp_gpio_of_ids, &pdev->dev);
-		if (!of_id) {
-			dev_err(&pdev->dev, "Unable to match OF ID\n");
-			return -ENODEV;
-		}
-		soc_type = (uintptr_t) of_id->data;
+		soc_type = (uintptr_t)of_device_get_match_data(&pdev->dev);
 	} else {
 		const struct acpi_device_id *acpi_id;
 
-- 
2.17.0

  parent reply	other threads:[~2018-04-30  7:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  7:38 [PATCH 01/12] gpio: 74xx-mmio: " Thierry Reding
2018-04-30  7:38 ` [PATCH 02/12] gpio: dwapb: " Thierry Reding
2018-04-30  7:38 ` [PATCH 03/12] gpio: ge: " Thierry Reding
2018-04-30  7:38 ` [PATCH 04/12] gpio: ingenic: " Thierry Reding
2018-04-30  7:38 ` [PATCH 05/12] gpio: mxs: " Thierry Reding
2018-04-30  7:38 ` [PATCH 06/12] gpio: palmas: " Thierry Reding
2018-04-30  7:38 ` [PATCH 07/12] gpio: pca953x: " Thierry Reding
2018-04-30  7:38 ` [PATCH 08/12] gpio: pxa: " Thierry Reding
2018-04-30  7:38 ` [PATCH 09/12] gpio: syscon: " Thierry Reding
2018-04-30  7:38 ` [PATCH 10/12] gpio: ts4900: " Thierry Reding
2018-04-30  7:38 ` [PATCH 11/12] gpio: vf610: " Thierry Reding
2018-04-30  7:38 ` Thierry Reding [this message]
2018-05-02 12:44 ` [PATCH 01/12] gpio: 74xx-mmio: " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180430073819.31827-12-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 12/12] gpio: xlp: Use of_device_get_match_data()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).