LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 01/12] gpio: 74xx-mmio: Use of_device_get_match_data()
@ 2018-04-30  7:38 Thierry Reding
  2018-04-30  7:38 ` [PATCH 02/12] gpio: dwapb: " Thierry Reding
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: Thierry Reding @ 2018-04-30  7:38 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-gpio, linux-kernel

From: Thierry Reding <treding@nvidia.com>

Use of_device_get_match_data() instead of open-coding it.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpio/gpio-74xx-mmio.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c
index 0475e8ec96d0..49616ec815ee 100644
--- a/drivers/gpio/gpio-74xx-mmio.c
+++ b/drivers/gpio/gpio-74xx-mmio.c
@@ -105,27 +105,22 @@ static int mmio_74xx_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
 
 static int mmio_74xx_gpio_probe(struct platform_device *pdev)
 {
-	const struct of_device_id *of_id;
 	struct mmio_74xx_gpio_priv *priv;
 	struct resource *res;
 	void __iomem *dat;
 	int err;
 
-	of_id = of_match_device(mmio_74xx_gpio_ids, &pdev->dev);
-	if (!of_id)
-		return -ENODEV;
-
 	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
 
+	priv->flags = (uintptr_t)of_device_get_match_data(&pdev->dev);
+
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	dat = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(dat))
 		return PTR_ERR(dat);
 
-	priv->flags = (uintptr_t) of_id->data;
-
 	err = bgpio_init(&priv->gc, &pdev->dev,
 			 DIV_ROUND_UP(MMIO_74XX_BIT_CNT(priv->flags), 8),
 			 dat, NULL, NULL, NULL, NULL, 0);
-- 
2.17.0

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2018-05-02 12:44 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-30  7:38 [PATCH 01/12] gpio: 74xx-mmio: Use of_device_get_match_data() Thierry Reding
2018-04-30  7:38 ` [PATCH 02/12] gpio: dwapb: " Thierry Reding
2018-04-30  7:38 ` [PATCH 03/12] gpio: ge: " Thierry Reding
2018-04-30  7:38 ` [PATCH 04/12] gpio: ingenic: " Thierry Reding
2018-04-30  7:38 ` [PATCH 05/12] gpio: mxs: " Thierry Reding
2018-04-30  7:38 ` [PATCH 06/12] gpio: palmas: " Thierry Reding
2018-04-30  7:38 ` [PATCH 07/12] gpio: pca953x: " Thierry Reding
2018-04-30  7:38 ` [PATCH 08/12] gpio: pxa: " Thierry Reding
2018-04-30  7:38 ` [PATCH 09/12] gpio: syscon: " Thierry Reding
2018-04-30  7:38 ` [PATCH 10/12] gpio: ts4900: " Thierry Reding
2018-04-30  7:38 ` [PATCH 11/12] gpio: vf610: " Thierry Reding
2018-04-30  7:38 ` [PATCH 12/12] gpio: xlp: " Thierry Reding
2018-05-02 12:44 ` [PATCH 01/12] gpio: 74xx-mmio: " Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).