LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type
@ 2018-04-24 13:18 Luc Van Oostenryck
  2018-04-25  7:49 ` Sergey Matyukevich
  2018-04-30 10:28 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:18 UTC (permalink / raw)
  To: linux-kernel
  Cc: Luc Van Oostenryck, Igor Mitsyanko, Avinash Patil,
	Sergey Matyukevich, Kalle Valo, Vasily Ulyanov, Kees Cook,
	linux-wireless, netdev

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.

Fix this by returning 'netdev_tx_t' in this driver too.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 drivers/net/wireless/quantenna/qtnfmac/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c
index cf26c15a8..b3bfb4faa 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/core.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/core.c
@@ -76,7 +76,7 @@ static int qtnf_netdev_close(struct net_device *ndev)
 
 /* Netdev handler for data transmission.
  */
-static int
+static netdev_tx_t
 qtnf_netdev_hard_start_xmit(struct sk_buff *skb, struct net_device *ndev)
 {
 	struct qtnf_vif *vif;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type
  2018-04-24 13:18 [PATCH] qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type Luc Van Oostenryck
@ 2018-04-25  7:49 ` Sergey Matyukevich
  2018-04-30 10:28 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Sergey Matyukevich @ 2018-04-25  7:49 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: linux-kernel, Igor Mitsyanko, Avinash Patil, Sergey Matyukevich,
	Kalle Valo, Kees Cook, linux-wireless, netdev

Hi Luc and all,

> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
> 
> Fix this by returning 'netdev_tx_t' in this driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>  drivers/net/wireless/quantenna/qtnfmac/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c
> index cf26c15a8..b3bfb4faa 100644
> --- a/drivers/net/wireless/quantenna/qtnfmac/core.c
> +++ b/drivers/net/wireless/quantenna/qtnfmac/core.c
> @@ -76,7 +76,7 @@ static int qtnf_netdev_close(struct net_device *ndev)
> 
>  /* Netdev handler for data transmission.
>   */
> -static int
> +static netdev_tx_t
>  qtnf_netdev_hard_start_xmit(struct sk_buff *skb, struct net_device *ndev)
>  {
>         struct qtnf_vif *vif;

Previous ACK from Igor slipped through the cracks due to
outlook/exchange issues. So here is another one.

Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>

Thanks for the fix !

Regards,
Sergey

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type
  2018-04-24 13:18 [PATCH] qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type Luc Van Oostenryck
  2018-04-25  7:49 ` Sergey Matyukevich
@ 2018-04-30 10:28 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-04-30 10:28 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: linux-kernel, Luc Van Oostenryck, Igor Mitsyanko, Avinash Patil,
	Sergey Matyukevich, Vasily Ulyanov, Kees Cook, linux-wireless,
	netdev

Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote:

> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
> 
> Fix this by returning 'netdev_tx_t' in this driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>

Patch applied to wireless-drivers-next.git, thanks.

3ff6ee28535f qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type

-- 
https://patchwork.kernel.org/patch/10359851/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-30 10:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:18 [PATCH] qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type Luc Van Oostenryck
2018-04-25  7:49 ` Sergey Matyukevich
2018-04-30 10:28 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).