LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Darren Kenny <darren.kenny@oracle.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Anthoine Bourgeois" <anthoine.bourgeois@blade-group.com>
Subject: Re: [PATCH] KVM: X86: Limit timer frequency with more smaller interval
Date: Mon, 30 Apr 2018 13:31:49 +0100	[thread overview]
Message-ID: <20180430123149.mroow2pdhglqesrn@starbug-mbp.local> (raw)
In-Reply-To: <1525055900-20729-1-git-send-email-wanpengli@tencent.com>

Hi Wanpeng Li,

On Sun, Apr 29, 2018 at 07:38:20PM -0700, Wanpeng Li wrote:
>From: Wanpeng Li <wanpengli@tencent.com>
>
>Anthoine reported:
> The period used by Windows change over time but it can be 1 milliseconds
> or less. I saw the limit_periodic_timer_frequency print so 500
> microseconds is sometimes reached.
>
>This patchs limits timer frequency with more smaller interval 200ms(5000Hz)
>to leave some headroom as Paolo suggested since Windows 10 changed the
>scheduler tick limit from 1024 Hz to 2048 Hz.

I would suggest re-writing this slightly, removing the 'this patch'
as some people suggested in other threads, and maybe some other
small re-wording, e.g.:

  As suggested by Paolo, lower the timer frequency limit to a
  smaller interval of 200 ms (5000 Hz) to leave some headroom. This
  is required due to Windows 10 changing the scheduler tick limit
  from 1024 Hz to 2048 Hz.

Also, in the subject line, maybe write it as 'Lower timer frequency
limit to 200ms'?

>
>Reported-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
>Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>Cc: Paolo Bonzini <pbonzini@redhat.com>
>Cc: Radim Krčmář <rkrcmar@redhat.com>
>Cc: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
>Signed-off-by: Wanpeng Li <wanpengli@tencent.com>

With those changes (or similar):

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>

>---
> arch/x86/kvm/x86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>index 51ecd38..dc47073 100644
>--- a/arch/x86/kvm/x86.c
>+++ b/arch/x86/kvm/x86.c
>@@ -114,7 +114,7 @@ module_param(ignore_msrs, bool, S_IRUGO | S_IWUSR);
> static bool __read_mostly report_ignored_msrs = true;
> module_param(report_ignored_msrs, bool, S_IRUGO | S_IWUSR);
>
>-unsigned int min_timer_period_us = 500;
>+unsigned int min_timer_period_us = 200;
> module_param(min_timer_period_us, uint, S_IRUGO | S_IWUSR);
>
> static bool __read_mostly kvmclock_periodic_sync = true;
>-- 
>2.7.4
>

  reply	other threads:[~2018-04-30 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  2:38 Wanpeng Li
2018-04-30 12:31 ` Darren Kenny [this message]
2018-05-04 12:28 ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180430123149.mroow2pdhglqesrn@starbug-mbp.local \
    --to=darren.kenny@oracle.com \
    --cc=anthoine.bourgeois@blade-group.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --subject='Re: [PATCH] KVM: X86: Limit timer frequency with more smaller interval' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).