LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: bhelgaas@google.com, Joao.Pinto@synopsys.com,
	jingoohan1@gmail.com, kishon@ti.com, robh+dt@kernel.org,
	mark.rutland@arm.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v8 3/9] PCI: endpoint: functions/pci-epf-test: Add second entry
Date: Mon, 30 Apr 2018 15:22:13 +0100	[thread overview]
Message-ID: <20180430142213.GC32033@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <c2b6cb8de2502e1b5352be3b6d687b1cb4b7033a.1524829928.git.gustavo.pimentel@synopsys.com>

On Fri, Apr 27, 2018 at 12:59:58PM +0100, Gustavo Pimentel wrote:
> Add a seconds entry on the pci_epf_test_ids structure that disables the

"Add a second entry..."

> linkup_notifier parameter on driver for the DesignWare EP.
> 
> Allow DesignWare EPs that doesn't have linkup notification signal to work
> with pcitest.
> 
> Update the binding documentation accordingly.
> 
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Change v2->v3:
>  - Added second entry in pci_epf_test_ids structure.
>  - Remove test_reg_bar field assignment on second entry.
> Changes v3->v4:
>  - Nothing changed, just to follow the patch set version.
> Changes v4->v5:
>  - Changed pci_epf_test_cfg2 to pci_epf_test_designware.
> Changes v5->v6:
>  - Changed name field from pci_epf_test_designware to pci_epf_test_dw.
> Changes v6->v7:
>  - Changed variable name from data_cfg2 to data_linkup_notifier_disabled.
> Changes v7->v8:
>  - Patch description rework for an imperative verbal mode.
> 
>  Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++
>  drivers/pci/endpoint/functions/pci-epf-test.c            | 8 ++++++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt
> index 3b68b95..dc39f47 100644
> --- a/Documentation/PCI/endpoint/function/binding/pci-test.txt
> +++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt
> @@ -1,6 +1,8 @@
>  PCI TEST ENDPOINT FUNCTION
>  
>  name: Should be "pci_epf_test" to bind to the pci_epf_test driver.
> +name: Should be "pci_epf_test_dw" to bind to the pci_epf_test driver
> +      with a custom configuration for the designware EP.
>  
>  Configurable Fields:
>  vendorid	 : should be 0x104c
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 7cef851..4ab463b 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf)
>  	return 0;
>  }
>  
> +static const struct pci_epf_test_data data_linkup_notifier_disabled = {
> +	.linkup_notifier = false
> +};
> +
>  static const struct pci_epf_device_id pci_epf_test_ids[] = {
>  	{
>  		.name = "pci_epf_test",
>  	},
> +	{
> +		.name = "pci_epf_test_dw",
> +		.driver_data = (kernel_ulong_t)&data_linkup_notifier_disabled,

You have not answered my question on this though:

https://marc.info/?l=linux-pci&m=152476180723047&w=2

> +	},
>  	{},
>  };
>  
> -- 
> 2.7.4
> 
> 

  reply	other threads:[~2018-04-30 14:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 11:59 [PATCH v8 0/9] DesignWare EP support and code clean up Gustavo Pimentel
2018-04-27 11:59 ` [PATCH v8 1/9] bindings: PCI: designware: Example update Gustavo Pimentel
2018-04-27 11:59 ` [PATCH v8 2/9] PCI: dwc: Add support for EP mode Gustavo Pimentel
2018-04-27 11:59 ` [PATCH v8 3/9] PCI: endpoint: functions/pci-epf-test: Add second entry Gustavo Pimentel
2018-04-30 14:22   ` Lorenzo Pieralisi [this message]
2018-04-30 16:36     ` Gustavo Pimentel
2018-04-27 11:59 ` [PATCH v8 4/9] bindings: PCI: designware: Add support for EP in DesignWare driver Gustavo Pimentel
2018-04-27 12:00 ` [PATCH v8 5/9] misc: pci_endpoint_test: Add DesignWare EP entry Gustavo Pimentel
2018-04-27 12:00 ` [PATCH v8 6/9] PCI: dwc: Define maximum number of vectors Gustavo Pimentel
2018-04-27 12:00 ` [PATCH v8 7/9] PCI: dwc: Replace lower into upper case characters Gustavo Pimentel
2018-04-27 12:00 ` [PATCH v8 8/9] PCI: dwc: Small computation improvement Gustavo Pimentel
2018-04-27 12:00 ` [PATCH v8 9/9] PCI: dwc: Replace magic number by defines Gustavo Pimentel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180430142213.GC32033@e107981-ln.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v8 3/9] PCI: endpoint: functions/pci-epf-test: Add second entry' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).