LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: omap1: osk: use device properties for at24 eeprom
@ 2018-04-04 12:38 Bartosz Golaszewski
  2018-05-01 15:16 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2018-04-04 12:38 UTC (permalink / raw)
  To: Aaro Koskinen, Tony Lindgren, Russell King
  Cc: linux-omap, linux-arm-kernel, linux-kernel, Bartosz Golaszewski

We want to work towards phasing out the at24_platform_data structure.
There are few users and its contents can be represented using generic
device properties. Using device properties only will allow us to
significantly simplify the at24 configuration code.

Remove the at24_platform_data structure and replace it with an array
of property entries. Drop the byte_len/size property, as the model name
already implies the EEPROM's size.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 arch/arm/mach-omap1/board-osk.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c
index c66372ed29e2..9ffa8d755a59 100644
--- a/arch/arm/mach-omap1/board-osk.c
+++ b/arch/arm/mach-omap1/board-osk.c
@@ -303,22 +303,22 @@ static const struct omap_lcd_config osk_lcd_config __initconst = {
 #ifdef	CONFIG_OMAP_OSK_MISTRAL
 
 #include <linux/input.h>
-#include <linux/platform_data/at24.h>
+#include <linux/property.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
 
 #include <linux/platform_data/keypad-omap.h>
 
-static struct at24_platform_data at24c04 = {
-	.byte_len	= SZ_4K / 8,
-	.page_size	= 16,
+static const struct property_entry mistral_at24_properties[] = {
+	PROPERTY_ENTRY_U32("pagesize", 16),
+	{ }
 };
 
 static struct i2c_board_info __initdata mistral_i2c_board_info[] = {
 	{
 		/* NOTE:  powered from LCD supply */
 		I2C_BOARD_INFO("24c04", 0x50),
-		.platform_data	= &at24c04,
+		.properties = mistral_at24_properties,
 	},
 	/* TODO when driver support is ready:
 	 *  - optionally ov9640 camera sensor at 0x30
-- 
2.16.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: omap1: osk: use device properties for at24 eeprom
  2018-04-04 12:38 [PATCH] ARM: omap1: osk: use device properties for at24 eeprom Bartosz Golaszewski
@ 2018-05-01 15:16 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2018-05-01 15:16 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Aaro Koskinen, Russell King, linux-omap, linux-arm-kernel, linux-kernel

* Bartosz Golaszewski <brgl@bgdev.pl> [180404 05:39]:
> We want to work towards phasing out the at24_platform_data structure.
> There are few users and its contents can be represented using generic
> device properties. Using device properties only will allow us to
> significantly simplify the at24 configuration code.
> 
> Remove the at24_platform_data structure and replace it with an array
> of property entries. Drop the byte_len/size property, as the model name
> already implies the EEPROM's size.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

Applying into omap-for-v4.18/omap1 thanks.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-01 15:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-04 12:38 [PATCH] ARM: omap1: osk: use device properties for at24 eeprom Bartosz Golaszewski
2018-05-01 15:16 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).