LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Keerthy <j-keerthy@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	bcousson@baylibre.com, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type
Date: Tue, 1 May 2018 08:33:50 -0700	[thread overview]
Message-ID: <20180501153350.GE98604@atomide.com> (raw)
In-Reply-To: <5423d98d-6c32-56f4-d228-bd1d33d9dff1@ti.com>

* Keerthy <j-keerthy@ti.com> [180423 10:32]:
> 
> 
> On Friday 20 April 2018 05:08 PM, Peter Ujfalusi wrote:
> > Hi,
> > 
> > In linux-next I started to see: https://pastebin.com/wrDdptzh
> > [    2.813985] ------------[ cut here ]------------
> > [    2.818746] WARNING: CPU: 0 PID: 19 at /home/ujfalusi/work/kernel/github.omap-audio.linux-audio/drivers/irqchip/irq-gic.c:1016 gic_irq_domain_translate+0xd4/0xec
> > [    2.833311] Modules linked in:
> > [    2.836417] CPU: 0 PID: 19 Comm: kworker/0:2 Not tainted 4.17.0-rc1-next-20180420-00057-gffd03ee19b9b #182
> > [    2.846113] Hardware name: Generic AM43 (Flattened Device Tree)
> > [    2.852073] Workqueue: events deferred_probe_work_func
> > ...
> > 
> > Becasue most of the am437x boards had IRQ_TYPE_NONE for tps65218.
> > 
> > According to the datasheet [1] the interrult line is low active, so fix up the board
> > DTS files.
> > 
> > Interestingly the am437x-sk-evm had IRQ_TYPE_LEVEL_HIGH, which is not matching
> > with the datasheet.
> > 
> > [1] http://www.ti.com/lit/ds/symlink/tps65218.pdf, page 8.
> 
> For the series:
> 
> Reviewed-by: Keerthy <j-keerthy@ti.com>
> 
> Also Boot tested on AM437X-GP-EVM with the patch 1 of the series and i
> do not see the error above.

Thanks applying all into omap-for-v4.18/dt.

Tony

      reply	other threads:[~2018-05-01 15:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 11:38 Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 1/4] ARM: dts: am437x-gp-evm: " Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 2/4] ARM: dts: am437x-cm-t43: " Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 3/4] ARM: dts: am437x-epos-evm: " Peter Ujfalusi
2018-04-20 11:38 ` [PATCH 4/4] ARM: dts: am437x-sk-evm: " Peter Ujfalusi
2018-04-23 10:31 ` [PATCH 0/4] ARM: dts: am437x boards: " Keerthy
2018-05-01 15:33   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180501153350.GE98604@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --subject='Re: [PATCH 0/4] ARM: dts: am437x boards: Correct tps65218 irq type' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).