LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Dan Williams <dcbw@redhat.com>
Cc: "Johan Hovold" <johan@kernel.org>,
	"Lars Melin" <larsm17@gmail.com>, "Bjørn Mork" <bjorn@mork.no>,
	"SZ Lin (林上智)" <sz.lin@moxa.com>, stable <stable@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: adding support for ublox R410M
Date: Wed, 2 May 2018 09:22:16 +0200	[thread overview]
Message-ID: <20180502072216.GA2285@localhost> (raw)
In-Reply-To: <5fb0b88573985caeb5ce2732ae217f60fbcfe965.camel@redhat.com>

On Thu, Apr 26, 2018 at 02:12:32PM -0500, Dan Williams wrote:
> On Thu, 2018-04-26 at 18:29 +0200, Johan Hovold wrote:
> > On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote:
> > > On 4/26/2018 23:12, Johan Hovold wrote:
> > > > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote:
> > > > > On 4/26/2018 18:39, Lars Melin wrote:
> > > > > > On 4/26/2018 18:19, Bjørn Mork wrote:
> > > > > > > Anyway, Qualcomm based designs are definitely handled by
> > > > > > > both drivers.  Using qcserial only makes sense if the
> > > > > > > interface layout matches one of the defined shared
> > > > > > > schemes, which currently are:
> > > > > > > 
> > > > > > >      QCSERIAL_G2K = 0,    /* Gobi 2000 */
> > > > > > >      QCSERIAL_G1K = 1,    /* Gobi 1000 */
> > > > > > >      QCSERIAL_SWI = 2,    /* Sierra Wireless */
> > > > > > >      QCSERIAL_HWI = 3,    /* Huawei */
> > > > > > 
> > > > > > It seems to me that this Quectel device matches the
> > > > > > interface layout for Gobi1K:
> > > >
> > > > Yeah, but qcserial appears to select a different altsetting for
> > > > the DM port for Gobi 1000, an altsetting which this particular
> > > > device does not have.
> > > > 
> > > > I didn't re-read the full thread I referred to earlier, but I
> > > > think in it, Dan mentioned Gobi 1000 device requiring firmware
> > > > to be loaded too.
> > > > 
> > > > So if it's not a G1K device, we probably shouldn't be using
> > > > qcserial even if the interface layout happens to match.
> > >
> > > Good point, I forgot about the required firmware loading for
> > > Gobi1K.
> > > So this device should be handled by the option driver.
> > 
> > Yeah, we probably should document all of this at some point. :)
> > 
> > I didn't include the patch in this weeks -rc updates, but I've
> > queued it up for the next batch.
> 
> Option is likely the right driver for this device.
> 
> qcaux was mainly for mobile phones that have a TTY (often cdc-acm) as
> the modem port and a secondary DIAG/DM port driven by qcaux.  The DM
> port doesn't have an interrupt endpoint thus it's not a normal modem
> port requiring the larger buffers of option and its control signaling.
> 
> qcserial (as Bjorn mentioned) is only for actual Gobi-type devices with
> the specific layouts and the firmware loading requirement where the 1K
> and 2K devices start in a special 1-port mode waiting for firmware and
> then become 4-port devices on firmware reboot.

Thanks for that summary. I've applied SZ's patch now.

Johan

      parent reply	other threads:[~2018-05-02  7:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26  6:28 SZ Lin (林上智)
2018-04-26  7:09 ` Johan Hovold
2018-04-26  7:48   ` Lars Melin
2018-04-26  8:14     ` Johan Hovold
2018-04-26 11:19       ` Bjørn Mork
2018-04-26 11:39         ` Lars Melin
2018-04-26 11:40           ` Lars Melin
2018-04-26 16:12             ` Johan Hovold
2018-04-26 16:22               ` Lars Melin
2018-04-26 16:29                 ` Johan Hovold
2018-04-26 19:12                   ` Dan Williams
2018-04-27  2:14                     ` SZ Lin (林上智)
2018-05-02  7:22                     ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502072216.GA2285@localhost \
    --to=johan@kernel.org \
    --cc=bjorn@mork.no \
    --cc=dcbw@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=larsm17@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=sz.lin@moxa.com \
    --subject='Re: [PATCH] USB: serial: option: adding support for ublox R410M' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).