LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] tracing: Remove PPC32 wart from config TRACING_SUPPORT
@ 2018-05-02 11:29 Michael Ellerman
2018-05-02 12:50 ` Steven Rostedt
2018-05-08 14:52 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Michael Ellerman @ 2018-05-02 11:29 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, linuxppc-dev
config TRACING_SUPPORT has an exception for PPC32, because PPC32
didn't have irqflags tracing support.
But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
irqtrace support for 32-bit powerpc") (Jun 2009).
So remove the exception for PPC32 and the comment.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
kernel/trace/Kconfig | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index c4f0f2e4126e..dd6c0a2ad969 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -110,11 +110,7 @@ config GENERIC_TRACER
#
config TRACING_SUPPORT
bool
- # PPC32 has no irqflags tracing support, but it can use most of the
- # tracers anyway, they were tested to build and work. Note that new
- # exceptions to this list aren't welcomed, better implement the
- # irqflags tracing for your architecture.
- depends on TRACE_IRQFLAGS_SUPPORT || PPC32
+ depends on TRACE_IRQFLAGS_SUPPORT
depends on STACKTRACE_SUPPORT
default y
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: Remove PPC32 wart from config TRACING_SUPPORT
2018-05-02 11:29 [PATCH] tracing: Remove PPC32 wart from config TRACING_SUPPORT Michael Ellerman
@ 2018-05-02 12:50 ` Steven Rostedt
2018-05-08 14:52 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2018-05-02 12:50 UTC (permalink / raw)
To: Michael Ellerman; +Cc: mingo, linux-kernel, linuxppc-dev
On Wed, 2 May 2018 21:29:48 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:
> config TRACING_SUPPORT has an exception for PPC32, because PPC32
> didn't have irqflags tracing support.
>
> But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
> irqtrace support for 32-bit powerpc") (Jun 2009).
>
> So remove the exception for PPC32 and the comment.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Feel free to take this patch through the PPC tree.
Thanks!
-- Steve
> ---
> kernel/trace/Kconfig | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index c4f0f2e4126e..dd6c0a2ad969 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -110,11 +110,7 @@ config GENERIC_TRACER
> #
> config TRACING_SUPPORT
> bool
> - # PPC32 has no irqflags tracing support, but it can use most of the
> - # tracers anyway, they were tested to build and work. Note that new
> - # exceptions to this list aren't welcomed, better implement the
> - # irqflags tracing for your architecture.
> - depends on TRACE_IRQFLAGS_SUPPORT || PPC32
> + depends on TRACE_IRQFLAGS_SUPPORT
> depends on STACKTRACE_SUPPORT
> default y
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: tracing: Remove PPC32 wart from config TRACING_SUPPORT
2018-05-02 11:29 [PATCH] tracing: Remove PPC32 wart from config TRACING_SUPPORT Michael Ellerman
2018-05-02 12:50 ` Steven Rostedt
@ 2018-05-08 14:52 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2018-05-08 14:52 UTC (permalink / raw)
To: Michael Ellerman, rostedt, mingo; +Cc: linuxppc-dev, linux-kernel
On Wed, 2018-05-02 at 11:29:48 UTC, Michael Ellerman wrote:
> config TRACING_SUPPORT has an exception for PPC32, because PPC32
> didn't have irqflags tracing support.
>
> But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
> irqtrace support for 32-bit powerpc") (Jun 2009).
>
> So remove the exception for PPC32 and the comment.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/0ea5ee035133aeb549883ddc604a65
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-08 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 11:29 [PATCH] tracing: Remove PPC32 wart from config TRACING_SUPPORT Michael Ellerman
2018-05-02 12:50 ` Steven Rostedt
2018-05-08 14:52 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).