LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<cgroups@vger.kernel.org>, <kernel-team@fb.com>,
	Michal Hocko <mhocko@suse.com>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2] mm: introduce memory.min
Date: Wed, 2 May 2018 13:52:39 +0100	[thread overview]
Message-ID: <20180502125234.GA4025@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <20180502123040.GA16060@cmpxchg.org>

On Wed, May 02, 2018 at 08:30:40AM -0400, Johannes Weiner wrote:
> On Mon, Apr 23, 2018 at 01:36:10PM +0100, Roman Gushchin wrote:
> > @@ -59,6 +59,12 @@ enum memcg_memory_event {
> >  	MEMCG_NR_MEMORY_EVENTS,
> >  };
> >  
> > +enum mem_cgroup_protection {
> > +	MEMCG_PROT_NONE,
> > +	MEMCG_PROT_LOW,
> > +	MEMCG_PROT_HIGH,
> 
> Ha, HIGH doesn't make much sense, but I went back and it's indeed what
> I suggested. Must have been a brainfart. This should be
> 
> MEMCG_PROT_NONE,
> MEMCG_PROT_LOW,
> MEMCG_PROT_MIN
> 
> right? To indicate which type of protection is applying.

Hm, I wasn't actually sure if it was a typo or not :)

But I thought that MEMCG_PROT_HIGH means a higher level
of protection than MEMCG_PROT_LOW, which sounds reasonable.

So, I'm fine with either option.

> 
> The rest of the patch looks good:
> 
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> 

Thanks!

Can you, also, please, take a look at this one:
https://lkml.org/lkml/2018/4/24/703.

Thank you!

      reply	other threads:[~2018-05-02 12:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 12:36 Roman Gushchin
2018-04-24 12:30 ` Vladimir Davydov
2018-04-24 13:54   ` Roman Gushchin
2018-04-25 10:52     ` Vladimir Davydov
2018-04-25 12:38       ` Roman Gushchin
2018-05-02 13:38     ` Johannes Weiner
2018-05-02 12:30 ` Johannes Weiner
2018-05-02 12:52   ` Roman Gushchin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502125234.GA4025@castle.DHCP.thefacebook.com \
    --to=guro@fb.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=tj@kernel.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v2] mm: introduce memory.min' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).