LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Eyal Reizer <eyalreizer@gmail.com>
Cc: bcousson@baylibre.com, robh+dt@kernel.org, mark.rutland@arm.com,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Eyal Reizer <eyalr@ti.com>
Subject: Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support
Date: Wed, 2 May 2018 07:51:00 -0700	[thread overview]
Message-ID: <20180502145100.GK98604@atomide.com> (raw)
In-Reply-To: <1525159453-32489-1-git-send-email-eyalr@ti.com>

* Eyal Reizer <eyalreizer@gmail.com> [180501 00:26]:
> enable mmc3 used for wlan and uart1 used for bluetooth
> configure the gpios used for wlan and bluetooth controls
> add fixed voltage regulator used for wlan power control
...
>  / {
>  	model = "TI AM437x SK EVM";
> @@ -158,6 +159,22 @@
>  			};
>  		};
>  	};
> +
> +	vmmcwl_fixed: fixedregulator-mmcwl {
> +		/*
> +		 * WL_EN is not SDIO standard compliant. It is an out of band
> +		 * signal and hard to be dealt with in a standard way by the
> +		 * SDIO core driver.
> +		 * So modelling the WL_EN line as a regulator was a natural
> +		 * choice as the MMC core already deals with MMC supplies.
> +		 */
> +		compatible = "regulator-fixed";
> +		regulator-name = "vmmcwl_fixed";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		gpio = <&gpio4 8 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
>  };

Interesting that it needs much longer delay here compared to the
earlier?

BTW, I do have a patch in work to add pwrseq support for wlcore that
allows leaving out the regulator here. It still needs a bit more
work though.

And I also have a series in work to make wlcore use runtime PM that
needs even more work, just FYI to avoid any duplicate work.

Hmm you don't happen to have a patch series somewhere making
wlcore use the SDIO dat lien interrupt?

I think we should use that when idle rather than the (edge) gpio
interrupt as the SDIO dat interrupt is level sensitive and wired
to the always on gpio bank for most SDIO controller instances.
On runtime PM wakeup, there's no status anywhere to been with the
GPIO edge interrupt.

Regards,

Tony

  parent reply	other threads:[~2018-05-02 14:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01  7:24 Eyal Reizer
2018-05-02  8:30 ` Sekhar Nori
2018-05-02 13:40   ` Reizer, Eyal
2018-05-02 14:51 ` Tony Lindgren [this message]
2018-05-03  6:41   ` [EXTERNAL] " Reizer, Eyal
2018-05-03 14:17     ` Tony Lindgren
2018-05-06  7:45       ` Reizer, Eyal
2018-05-06 16:56         ` Tony Lindgren
2018-05-07  6:55           ` Reizer, Eyal
2018-05-07 15:08             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502145100.GK98604@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eyalr@ti.com \
    --cc=eyalreizer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).