LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Boris Brezillon <boris.brezillon@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/6] clocksource: rework Atmel TCB timer driver
Date: Wed, 2 May 2018 20:10:46 +0200	[thread overview]
Message-ID: <20180502181046.GG19273@piout.net> (raw)
In-Reply-To: <20180502133418.xa26c5ta2ytxxjcn@linutronix.de>

On 02/05/2018 15:34:18+0200, Sebastian Andrzej Siewior wrote:
> On 2018-04-26 20:52:33 [+0200], Alexandre Belloni wrote:
> > 
> > I don't remember you posted anything for the TCB. Wasn't it focused on
> > getting rid of the PIT irq?
> 
> the PIT irq which was shared with the UART one some devices, yes this
> was part of it. The other essential piece was using a higher frequency
> for the device:
>   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/tree/patches/clocksource-tclib-allow-higher-clockrates.patch?h=linux-4.14.y-rt-patches
> 
> > As said below, this is solving multiple issues, including the one for
> > SoCs that don't have the PIT.
> will the PIT be removed? Where it needs the PIT?
> 

The last patch is unselecting the PIT driver so by default it is not
enabled. The PIT driver will stay just in case someone has to use it
e.g. when they are using all the TCB channels for something else.
However, recent Atmel SoC have a TCB without any output so it can ony be
used as a timer. Some other SoCs don't have a PIT at all.

> > I don't think you ending up with nothing but probably you removed the
> > PIT and kept ATMEL_TCLIB which is the combination that is really
> > difficult to protect from. I don't think it is worth the added Kconfig
> > complexity.
> 
> TCLIB was still enabled yes. It is 'oldconfig'.
> 

Hum, ok, I'll try to provide a cleaner path.

> > The remaining one would be "clocksource: TCLIB: Allow higher clock rates
> > for clock events"
> 
> I see. So I would need to keep that patch in queue after it was
> dismissed from duty…

Boris suggested a DT binding to allow changing the rate but it didn't
reach consensus at the time. this is something that will ne to be
revived at some point and I would very much like having that upstream
too.

-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-02 18:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 10:51 Alexandre Belloni
2018-04-18 10:51 ` [PATCH v4 1/6] ARM: at91: add TCB registers definitions Alexandre Belloni
2018-04-26 16:52   ` Sebastian Andrzej Siewior
2018-04-26 17:48     ` Alexandre Belloni
2018-04-18 10:51 ` [PATCH v4 2/6] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks Alexandre Belloni
2018-04-18 10:51 ` [PATCH v4 3/6] clocksource/drivers: atmel-pit: make option silent Alexandre Belloni
2018-04-18 10:51 ` [PATCH v4 4/6] ARM: at91: Implement clocksource selection Alexandre Belloni
2018-04-18 10:51 ` [PATCH v4 5/6] ARM: configs: at91: use new TCB timer driver Alexandre Belloni
2018-04-18 10:51 ` [PATCH v4 6/6] ARM: configs: at91: unselect PIT Alexandre Belloni
2018-04-26 16:46 ` [PATCH v4 0/6] clocksource: rework Atmel TCB timer driver Sebastian Andrzej Siewior
2018-04-26 18:52   ` Alexandre Belloni
2018-05-02 13:34     ` Sebastian Andrzej Siewior
2018-05-02 18:10       ` Alexandre Belloni [this message]
2018-05-15 17:26         ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502181046.GG19273@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=bigeasy@linutronix.de \
    --cc=boris.brezillon@bootlin.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH v4 0/6] clocksource: rework Atmel TCB timer driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).