LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for May 2 (objtool bug!)
Date: Wed, 2 May 2018 16:06:25 -0500	[thread overview]
Message-ID: <20180502210625.pehvcgtlqwqznnry@treble> (raw)
In-Reply-To: <5ed0305b-bca8-3b50-7d33-32c5754a81fc@infradead.org>

On Wed, May 02, 2018 at 08:59:38AM -0700, Randy Dunlap wrote:
> On 05/02/2018 08:43 AM, Josh Poimboeuf wrote:
> > On Wed, May 02, 2018 at 08:37:53AM -0700, Randy Dunlap wrote:
> >> On 05/01/2018 11:59 PM, Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> Changes since 20180501:
> >>>
> >>
> >> on x86_64 randconfig:
> >>
> >>   CC      fs/cifs/smbencrypt.o
> >> drivers/char/ipmi/ipmi_ssif.o: warning: objtool: return_hosed_msg()+0x0: infinite recursion (objtool bug!)
> >> drivers/char/ipmi/ipmi_ssif.o: warning: objtool: deliver_recv_msg()+0x0: infinite recursion (objtool bug!)
> > 
> > Can you share the object file (or at least the .config and GCC version)?
> > 
> 
> gcc (SUSE Linux) 4.8.5
> 
> config and .o file are attached.

Thanks, can you verify this fixes it?

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 92b6a2c21631..dae568fef2c1 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -190,9 +190,13 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func,
 					continue;
 
 				if (recursion == 5) {
-					WARN_FUNC("infinite recursion (objtool bug!)",
-						  dest->sec, dest->offset);
-					return -1;
+					/*
+					 * Infinite recursion: two functions
+					 * have sibling calls to each other.
+					 * This is a very rare case.  It means
+					 * they aren't dead ends.
+					 */
+					return 0;
 				}
 
 				return __dead_end_function(file, dest_func,

  reply	other threads:[~2018-05-02 21:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  6:59 linux-next: Tree for May 2 Stephen Rothwell
2018-05-02 15:37 ` linux-next: Tree for May 2 (objtool bug!) Randy Dunlap
2018-05-02 15:43   ` Josh Poimboeuf
2018-05-02 15:59     ` Randy Dunlap
2018-05-02 21:06       ` Josh Poimboeuf [this message]
2018-05-02 21:34         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502210625.pehvcgtlqwqznnry@treble \
    --to=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: linux-next: Tree for May 2 (objtool bug'\!')' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).