LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Akshu Agrawal <akshu.agrawal@amd.com>,
	"djkurtz@chromium.org" <djkurtz@chromium.org>,
	"Alexander.Deucher@amd.com" <Alexander.Deucher@amd.com>,
	Support Opensource <Support.Opensource@diasemi.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"moderated list:SOUND" <alsa-devel@alsa-project.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems
Date: Thu, 3 May 2018 10:39:19 +0900	[thread overview]
Message-ID: <20180503013919.GN2714@sirena.org.uk> (raw)
In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1E9782@SW-EX-MBX01.diasemi.com>

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

On Wed, May 02, 2018 at 10:13:55AM +0000, Adam Thomson wrote:
> On 01 May 2018 21:50, Mark Brown wrote:

> > There's a lot of things that ACPI *should* do but doesn't - it's a bit
> > of a shambles how ACPI standards get defined and what's there is not
> > really intended to handle systems like these semi-embedded ones.  One of
> > the big gaps in ACPI is that it has no handling at all of clocks, that's
> > supposed to be done transparently by firmware in the ACPI model.  What a
> > lot of the embedded Intel people have been doing is coopting the DT
> > bindings wholesale for ACPI systems but that has problems when you get
> > into areas which should be handled in some way on ACPI systems like
> > power and unfortunately clocks are kind of power adjacent so might be a
> > bit sketchy here.

> Yes I was aware that previously that was the case, although have not followed
> this for a while. It just feels here that we should aim for something more
> generic rather than a device specific property/binding, if possible, as that
> feels messy to me and I'm sure other drivers could take advantage of this as
> well. I've not looked at the clock code in too much detail though, at least with
> regards to this area, so not sure how feasible that is.

> As a suggestion for ACPI would it be possible to re-use the 'clock-names'
> property and add something in the framework to handle this?

I completely agree that ACPI should have handling for clocks but it
really feels like something that should be done as a proper spec rather
than just ad hoc by Linux like the x86 embedded people often do - it's
too close to the power management stuff that ACPI definitely does
handle.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-05-03  1:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  9:23 Akshu Agrawal
2018-04-30 16:24 ` [alsa-devel] " Pierre-Louis Bossart
2018-05-01 14:31   ` Agrawal, Akshu
2018-05-01 15:59     ` Pierre-Louis Bossart
2018-04-30 19:05 ` Adam Thomson
2018-05-01 14:40   ` Agrawal, Akshu
2018-05-01 20:50   ` Mark Brown
2018-05-02 10:13     ` Adam Thomson
2018-05-03  1:39       ` Mark Brown [this message]
2018-05-03  8:20         ` [alsa-devel] " Adam Thomson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503013919.GN2714@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=akshu.agrawal@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=djkurtz@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).