LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Pavel Tatashin <pasha.tatashin@oracle.com> To: pasha.tatashin@oracle.com, steven.sistare@oracle.com, daniel.m.jordan@oracle.com, linux-kernel@vger.kernel.org, jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, gregkh@linuxfoundation.org Subject: [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close() Date: Wed, 2 May 2018 23:59:30 -0400 [thread overview] Message-ID: <20180503035931.22439-2-pasha.tatashin@oracle.com> (raw) In-Reply-To: <20180503035931.22439-1-pasha.tatashin@oracle.com> Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration of lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards this lock prevents scaling if device_shutdown() function is multi-threaded. It is not necessary to hold this lock during ixgbe_close_suspend() as it is not held when ixgbe_close() is called also during shutdown but for kexec case. Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index afadba99f7b8..e7875b58854b 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -6748,8 +6748,15 @@ static int __ixgbe_shutdown(struct pci_dev *pdev, bool *enable_wake) rtnl_lock(); netif_device_detach(netdev); - if (netif_running(netdev)) + if (netif_running(netdev)) { + /* Suspend takes a long time, device_shutdown may be + * parallelized this function, so drop lock for the + * duration of this call. + */ + rtnl_unlock(); ixgbe_close_suspend(adapter); + rtnl_lock(); + } ixgbe_clear_interrupt_scheme(adapter); rtnl_unlock(); -- 2.17.0
next prev parent reply other threads:[~2018-05-03 3:59 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-03 3:59 [PATCH 0/2] multi-threading device shutdown Pavel Tatashin 2018-05-03 3:59 ` Pavel Tatashin [this message] 2018-05-03 13:20 ` [PATCH 1/2] ixgbe: release lock for the duration of ixgbe_suspend_close() Alexander Duyck 2018-05-03 13:30 ` Pavel Tatashin 2018-05-03 13:46 ` Alexander Duyck 2018-05-03 14:01 ` Steven Sistare 2018-05-03 14:23 ` Pavel Tatashin 2018-05-03 3:59 ` [PATCH 2/2] drivers core: multi-threading device shutdown Pavel Tatashin 2018-05-03 5:54 ` Tobin C. Harding 2018-05-03 13:38 ` Pavel Tatashin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180503035931.22439-2-pasha.tatashin@oracle.com \ --to=pasha.tatashin@oracle.com \ --cc=daniel.m.jordan@oracle.com \ --cc=gregkh@linuxfoundation.org \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=steven.sistare@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).