LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/6] x86/microcode/AMD: Check microcode container data in the late loader
Date: Thu, 3 May 2018 12:01:33 +0200	[thread overview]
Message-ID: <20180503100133.GB20023@pd.tnic> (raw)
In-Reply-To: <9cf234e8-4d96-46f0-70e0-7d60d49671d8@maciej.szmigiero.name>

On Wed, May 02, 2018 at 02:47:39AM +0200, Maciej S. Szmigiero wrote:
> On 01.05.2018 22:03, Borislav Petkov wrote:
> > On Tue, May 01, 2018 at 06:19:56PM +0200, Maciej S. Szmigiero wrote:
> >> -EINVAL cast to unsigned int is 4294967274 and this value is also
> >> a valid count of bytes to skip that this function can return.
> > 
> > And where exactly in the *old* code do we do that?
> 
> The old code returned this value as a signed int, but then any
> "patch_size" value (which is u32) above INT_MAX read from a section header
> wrapped around to a negative pseudo-error code (which likely didn't match
> any actual error number).

Lemme repeat my question: *where* *exactly* in the old code do we do that?

Feel free to paste snippets to show what you mean.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2018-05-03 10:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 21:34 [PATCH v5 0/6] x86/microcode/AMD: Check microcode file sanity before loading it Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 1/6] x86/microcode/AMD: Subtract SECTION_HDR_SIZE from file leftover length Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 2/6] x86/microcode/AMD: Add microcode container data checking functions Maciej S. Szmigiero
2018-04-30  9:04   ` Borislav Petkov
2018-04-30 22:27     ` Maciej S. Szmigiero
2018-05-01  8:18       ` Borislav Petkov
2018-05-01 16:19         ` Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 3/6] x86/microcode/AMD: Check microcode container data in the early loader Maciej S. Szmigiero
2018-04-30  9:05   ` Borislav Petkov
2018-04-30 22:27     ` Maciej S. Szmigiero
2018-05-01  8:44       ` Borislav Petkov
2018-04-23 21:34 ` [PATCH v5 4/6] x86/microcode/AMD: Check microcode container data in the late loader Maciej S. Szmigiero
2018-04-30  9:05   ` Borislav Petkov
2018-04-30 22:27     ` Maciej S. Szmigiero
2018-05-01  8:43       ` Borislav Petkov
2018-05-01 16:19         ` Maciej S. Szmigiero
2018-05-01 20:03           ` Borislav Petkov
2018-05-02  0:47             ` Maciej S. Szmigiero
2018-05-03 10:01               ` Borislav Petkov [this message]
2018-05-03 23:26                 ` Maciej S. Szmigiero
2018-05-07 16:35                   ` Borislav Petkov
2018-04-23 21:34 ` [PATCH v5 5/6] x86/microcode/AMD: Add a reminder about PATCH_MAX_SIZE macro Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 6/6] x86/microcode/AMD: Check the equivalence table size when scanning it Maciej S. Szmigiero
2018-04-30  9:05   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503100133.GB20023@pd.tnic \
    --to=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH v5 4/6] x86/microcode/AMD: Check microcode container data in the late loader' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).