LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3 1/4] tpm: Add explicit endianness cast
@ 2018-04-25 13:26 Thiebaud Weksteen
  2018-05-01 11:49 ` Jarkko Sakkinen
  0 siblings, 1 reply; 4+ messages in thread
From: Thiebaud Weksteen @ 2018-04-25 13:26 UTC (permalink / raw)
  To: jarkko.sakkinen, nayna, linux-integrity, linux-kernel, tweek
  Cc: linux-integrity, linux-kernel, Thiebaud Weksteen

Signed-off-by: Thiebaud Weksteen <tweek@google.com>
---
 drivers/char/tpm/tpm_eventlog_of.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm_eventlog_of.c b/drivers/char/tpm/tpm_eventlog_of.c
index 96fd5646f866..ea0f16f19d73 100644
--- a/drivers/char/tpm/tpm_eventlog_of.c
+++ b/drivers/char/tpm/tpm_eventlog_of.c
@@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip)
 	 * but physical tpm needs the conversion.
 	 */
 	if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) {
-		size = be32_to_cpup(sizep);
-		base = be64_to_cpup(basep);
+		size = be32_to_cpup((__force __be32 *)sizep);
+		base = be64_to_cpup((__force __be64 *)basep);
 	} else {
 		size = *sizep;
 		base = *basep;
-- 
2.17.0.484.g0c8726318c-goog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/4] tpm: Add explicit endianness cast
  2018-04-25 13:26 [PATCH v3 1/4] tpm: Add explicit endianness cast Thiebaud Weksteen
@ 2018-05-01 11:49 ` Jarkko Sakkinen
  2018-05-02  8:49   ` Thiebaud Weksteen
  0 siblings, 1 reply; 4+ messages in thread
From: Jarkko Sakkinen @ 2018-05-01 11:49 UTC (permalink / raw)
  To: Thiebaud Weksteen; +Cc: nayna, linux-integrity, linux-kernel

On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote:
> Signed-off-by: Thiebaud Weksteen <tweek@google.com>
> ---
>  drivers/char/tpm/tpm_eventlog_of.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_eventlog_of.c b/drivers/char/tpm/tpm_eventlog_of.c
> index 96fd5646f866..ea0f16f19d73 100644
> --- a/drivers/char/tpm/tpm_eventlog_of.c
> +++ b/drivers/char/tpm/tpm_eventlog_of.c
> @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip)
>  	 * but physical tpm needs the conversion.
>  	 */
>  	if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) {
> -		size = be32_to_cpup(sizep);
> -		base = be64_to_cpup(basep);
> +		size = be32_to_cpup((__force __be32 *)sizep);
> +		base = be64_to_cpup((__force __be64 *)basep);
>  	} else {
>  		size = *sizep;
>  		base = *basep;
> -- 
> 2.17.0.484.g0c8726318c-goog
> 

Repeal and replace, right (no change log)?

/Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/4] tpm: Add explicit endianness cast
  2018-05-01 11:49 ` Jarkko Sakkinen
@ 2018-05-02  8:49   ` Thiebaud Weksteen
  2018-05-03 12:40     ` Jarkko Sakkinen
  0 siblings, 1 reply; 4+ messages in thread
From: Thiebaud Weksteen @ 2018-05-02  8:49 UTC (permalink / raw)
  To: Jarkko Sakkinen; +Cc: Nayna Jain, linux-integrity, linux-kernel

On Tue, May 1, 2018 at 1:49 PM Jarkko Sakkinen <
jarkko.sakkinen@linux.intel.com> wrote:

> On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote:
> > Signed-off-by: Thiebaud Weksteen <tweek@google.com>
> > ---
> >  drivers/char/tpm/tpm_eventlog_of.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/char/tpm/tpm_eventlog_of.c
b/drivers/char/tpm/tpm_eventlog_of.c
> > index 96fd5646f866..ea0f16f19d73 100644
> > --- a/drivers/char/tpm/tpm_eventlog_of.c
> > +++ b/drivers/char/tpm/tpm_eventlog_of.c
> > @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip)
> >        * but physical tpm needs the conversion.
> >        */
> >       if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) {
> > -             size = be32_to_cpup(sizep);
> > -             base = be64_to_cpup(basep);
> > +             size = be32_to_cpup((__force __be32 *)sizep);
> > +             base = be64_to_cpup((__force __be64 *)basep);
> >       } else {
> >               size = *sizep;
> >               base = *basep;
> > --
> > 2.17.0.484.g0c8726318c-goog
> >

> Repeal and replace, right (no change log)?

Yep, that's right. Thanks.


> /Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/4] tpm: Add explicit endianness cast
  2018-05-02  8:49   ` Thiebaud Weksteen
@ 2018-05-03 12:40     ` Jarkko Sakkinen
  0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2018-05-03 12:40 UTC (permalink / raw)
  To: Thiebaud Weksteen; +Cc: Nayna Jain, linux-integrity, linux-kernel

On Wed, May 02, 2018 at 08:49:41AM +0000, Thiebaud Weksteen wrote:
> On Tue, May 1, 2018 at 1:49 PM Jarkko Sakkinen <
> jarkko.sakkinen@linux.intel.com> wrote:
> 
> > On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote:
> > > Signed-off-by: Thiebaud Weksteen <tweek@google.com>
> > > ---
> > >  drivers/char/tpm/tpm_eventlog_of.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/char/tpm/tpm_eventlog_of.c
> b/drivers/char/tpm/tpm_eventlog_of.c
> > > index 96fd5646f866..ea0f16f19d73 100644
> > > --- a/drivers/char/tpm/tpm_eventlog_of.c
> > > +++ b/drivers/char/tpm/tpm_eventlog_of.c
> > > @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip)
> > >        * but physical tpm needs the conversion.
> > >        */
> > >       if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) {
> > > -             size = be32_to_cpup(sizep);
> > > -             base = be64_to_cpup(basep);
> > > +             size = be32_to_cpup((__force __be32 *)sizep);
> > > +             base = be64_to_cpup((__force __be64 *)basep);
> > >       } else {
> > >               size = *sizep;
> > >               base = *basep;
> > > --
> > > 2.17.0.484.g0c8726318c-goog
> > >
> 
> > Repeal and replace, right (no change log)?
> 
> Yep, that's right. Thanks.

Done.

/Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-03 12:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-25 13:26 [PATCH v3 1/4] tpm: Add explicit endianness cast Thiebaud Weksteen
2018-05-01 11:49 ` Jarkko Sakkinen
2018-05-02  8:49   ` Thiebaud Weksteen
2018-05-03 12:40     ` Jarkko Sakkinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).