LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Gary R Hook <gary.hook@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log
Date: Thu, 3 May 2018 15:57:07 +0200	[thread overview]
Message-ID: <20180503135706.nypxlwlt7jhqhhum@8bytes.org> (raw)
In-Reply-To: <152520437211.30928.8410126837908568791.stgit@taos>

On Tue, May 01, 2018 at 02:52:52PM -0500, Gary R Hook wrote:
> @@ -567,7 +567,7 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt)
>  	}
>  
>  	if (type == EVENT_TYPE_IO_FAULT) {
> -		amd_iommu_report_page_fault(devid, domid, address, flags);
> +		amd_iommu_report_page_fault(devid, pasid, address, flags);

According to the spec this could be a domid or a pasid, it would be good
to make that visible in the error message, depending on the value of the
GN flag in the event entry.

But that can be done in a separate patch, I applied these two, thanks.

  reply	other threads:[~2018-05-03 13:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 19:52 [PATCH 0/2] Tweak AMD IOMMU logging Gary R Hook
2018-05-01 19:52 ` [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log Gary R Hook
2018-05-03 13:57   ` Joerg Roedel [this message]
2018-05-03 18:09     ` Gary R Hook
2018-05-03 20:29       ` Joerg Roedel
2018-05-01 19:53 ` [PATCH 2/2] iommu/amd - Update logging information for new event type Gary R Hook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503135706.nypxlwlt7jhqhhum@8bytes.org \
    --to=joro@8bytes.org \
    --cc=gary.hook@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).