LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Reizer, Eyal" <eyalr@ti.com>
Cc: Eyal Reizer <eyalreizer@gmail.com>,
	"bcousson@baylibre.com" <bcousson@baylibre.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support
Date: Thu, 3 May 2018 07:17:59 -0700	[thread overview]
Message-ID: <20180503141759.GP98604@atomide.com> (raw)
In-Reply-To: <5cc906da15da45ab96e06957f878b65b@ti.com>

* Reizer, Eyal <eyalr@ti.com> [180503 06:43]:
> > 
> > * Eyal Reizer <eyalreizer@gmail.com> [180501 00:26]:
> > > enable mmc3 used for wlan and uart1 used for bluetooth
> > > configure the gpios used for wlan and bluetooth controls
> > > add fixed voltage regulator used for wlan power control
> > ...
> > >  / {
> > >  	model = "TI AM437x SK EVM";
> > > @@ -158,6 +159,22 @@
> > >  			};
> > >  		};
> > >  	};
> > > +
> > > +	vmmcwl_fixed: fixedregulator-mmcwl {
> > > +		/*
> > > +		 * WL_EN is not SDIO standard compliant. It is an out of band
> > > +		 * signal and hard to be dealt with in a standard way by the
> > > +		 * SDIO core driver.
> > > +		 * So modelling the WL_EN line as a regulator was a natural
> > > +		 * choice as the MMC core already deals with MMC supplies.
> > > +		 */
> > > +		compatible = "regulator-fixed";
> > > +		regulator-name = "vmmcwl_fixed";
> > > +		regulator-min-microvolt = <1800000>;
> > > +		regulator-max-microvolt = <1800000>;
> > > +		gpio = <&gpio4 8 GPIO_ACTIVE_HIGH>;
> > > +		enable-active-high;
> > > +	};
> > >  };
> > 
> > Interesting that it needs much longer delay here compared to the
> > earlier?
> 
> Where do you see a delay in here?
> There is no startup-delay-us value used in this patch.

Oops sorry, I misread the voltage above as the startup-delay-us
value :)

> > BTW, I do have a patch in work to add pwrseq support for wlcore that
> > allows leaving out the regulator here. It still needs a bit more
> > work though.
> > 
> > And I also have a series in work to make wlcore use runtime PM that
> > needs even more work, just FYI to avoid any duplicate work.
> > 
> > Hmm you don't happen to have a patch series somewhere making
> > wlcore use the SDIO dat lien interrupt?
> wilink has always used out of band interrupt (using wlan_irq gpio).
> in-band interrupts was not supported.
> See section 10.5.2 in this the wl18xx hardware integration guide:
> http://www.ti.com/lit/ug/swru437/swru437.pdf

Hmm yeah I've been wondering about that. Why not follow the SDIO
standard here though? Do you have links to documentation explaining
that?

> > I think we should use that when idle rather than the (edge) gpio
> > interrupt as the SDIO dat interrupt is level sensitive and wired
> > to the always on gpio bank for most SDIO controller instances.
> > On runtime PM wakeup, there's no status anywhere to been with the
> > GPIO edge interrupt.
> > 
> I agree that it would have been better, especially for cases such as wake 
> On wlan, but again, in-band interrupt was something that was talked 
> about way back but it was never implemented.

I think we can have both if performance is the reason for the
out of band interrupt. We could still use SDIO dat line interrupt
during idle for wake-up events.

Regards,

Tony

  reply	other threads:[~2018-05-03 14:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01  7:24 Eyal Reizer
2018-05-02  8:30 ` Sekhar Nori
2018-05-02 13:40   ` Reizer, Eyal
2018-05-02 14:51 ` Tony Lindgren
2018-05-03  6:41   ` [EXTERNAL] " Reizer, Eyal
2018-05-03 14:17     ` Tony Lindgren [this message]
2018-05-06  7:45       ` Reizer, Eyal
2018-05-06 16:56         ` Tony Lindgren
2018-05-07  6:55           ` Reizer, Eyal
2018-05-07 15:08             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503141759.GP98604@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eyalr@ti.com \
    --cc=eyalreizer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).