LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mathieu Malaterre <malat@debian.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
Date: Thu, 3 May 2018 18:30:27 +0200 [thread overview]
Message-ID: <20180503163027.lthixenaguphn4du@kozik-lap> (raw)
In-Reply-To: <20180502201153.7459-1-malat@debian.org>
On Wed, May 02, 2018 at 10:11:52PM +0200, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]\+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0\+\(.*\) {/@0\1 {/g" {} +
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This will solve as a side effect warning:
>
> Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> v2: intermediate patch contained unrelated changes. restrict to S3 and Exynos*
>
> arch/arm/boot/dts/exynos5420.dtsi | 36 ++++++++++++++++++------------------
> arch/arm/boot/dts/s3c2416.dtsi | 8 ++++----
> 2 files changed, 22 insertions(+), 22 deletions(-)
>
Thanks, applied.
Best regards,
Krzysztof
next prev parent reply other threads:[~2018-05-03 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 12:46 [PATCH 04/25] " Mathieu Malaterre
2017-12-18 9:40 ` Krzysztof Kozlowski
2017-12-18 10:17 ` Mathieu Malaterre
2018-05-01 16:15 ` Krzysztof Kozlowski
2018-05-02 20:11 ` [PATCH v2] " Mathieu Malaterre
2018-05-03 16:30 ` Krzysztof Kozlowski [this message]
2018-05-03 16:35 ` Krzysztof Kozlowski
2018-05-03 18:47 ` Mathieu Malaterre
2018-05-03 18:44 ` [PATCH v3] " Mathieu Malaterre
2018-05-03 18:53 ` Krzysztof Kozlowski
2018-05-03 18:58 ` Mathieu Malaterre
2018-05-03 19:01 ` Krzysztof Kozlowski
2018-05-03 19:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503163027.lthixenaguphn4du@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--subject='Re: [PATCH v2] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).