LKML Archive on
help / color / mirror / Atom feed
From: Dmitry Osipenko <>
To: Thierry Reding <>,
	Jonathan Hunter <>,
	Peter De Schrijver <>,
	Prashant Gaikwad <>,
	Stephen Boyd <>,
	Michael Turquette <>,
	Linus Walleij <>,
	Marcel Ziswiler <>,
	Marc Dietrich <>
Subject: [PATCH v2 0/4] Restore ULPI USB on Tegra20
Date: Fri,  4 May 2018 01:55:32 +0300	[thread overview]
Message-ID: <> (raw)


This series of patches fixes ULPI USB on Tegra20. The original problem
was reported by Marcel Ziswiler, he found that "ulpi-link" clock was
incorrectly set to CDEV2 instead of PLL_P_OUT4. Marcel made a patch
that changed the "ulpi-link" clock to PLL_P_OUT4 and that fixed issue
with the USB for the devices that have CDEV2 being enabled by bootloader.
The patch got into the kernel and later Marc Dietrich found that USB
stopped working on the "paz00" Tegra20 board. After a bit of discussion
was revealed that PLL_P_OUT4 is the parent clock of the CDEV2 and clock
driver was setting CDEV2's parent incorrectly. The parent clock is actually
determined by the pinmuxing config of CDEV2 pingroup. This patchset fixes
the parent of CDEV2 clock by making Tegra's pinctrl driver a clock provider,
providing CDEV1/2 clock muxes (thanks to Peter De Schrijver for the
suggestion), and then setting these clock muxes as parents for the CDEV1/2
clocks. In the end Marcel's CDEV2->PLL_P_OUT4 change is reverted since CDEV2
(aka MCLK2) is the actual clock source for "ulpi-link".


	- Added new patch "Add quirk for getting CDEV1/2 clocks", assuring
	  that clk user won't get CDEV1/2 clocks until parent clk muxes
	  are available, i.e. resolves potential issue with CDEV-user driver
	  vs pinctrl driver probe order.

	- Factored out "pinctrl" patch from the patchset as was requested by
	  Linus Walleij.

	- Addressed v1 review comments: fixed swapped DEV1/2 clk div bits,
	  made DEV1/2 divs read-only, etc minor changes.

Dmitry Osipenko (4):
  clk: tegra20: Add DEV1/DEV2 OSC dividers
  clk: tegra20: Correct parents of CDEV1/2 clocks
  clk: tegra: Add quirk for getting CDEV1/2 clocks
  ARM: dts: tegra20: Revert "Fix ULPI regression on Tegra20"

 arch/arm/boot/dts/tegra20.dtsi  |  2 +-
 drivers/clk/tegra/clk-tegra20.c | 20 +++++++++++++++----
 drivers/clk/tegra/clk.c         | 34 ++++++++++++++++++++++++++++++++-
 3 files changed, 50 insertions(+), 6 deletions(-)


             reply	other threads:[~2018-05-03 22:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 22:55 Dmitry Osipenko [this message]
2018-05-03 22:55 ` [PATCH v2 1/4] clk: tegra20: Add DEV1/DEV2 OSC dividers Dmitry Osipenko
2018-05-03 22:55 ` [PATCH v2] pinctrl: tegra20: Provide CDEV1/2 clock muxes Dmitry Osipenko
2018-05-16 12:23   ` Linus Walleij
2018-05-16 14:05     ` Dmitry Osipenko
2018-05-03 22:55 ` [PATCH v2 2/4] clk: tegra20: Correct parents of CDEV1/2 clocks Dmitry Osipenko
2018-05-03 22:55 ` [PATCH v2 3/4] clk: tegra: Add quirk for getting " Dmitry Osipenko
2018-05-08 10:54   ` Peter De Schrijver
2018-05-03 22:55 ` [PATCH v2 4/4] ARM: dts: tegra20: Revert "Fix ULPI regression on Tegra20" Dmitry Osipenko
2018-05-04 10:40   ` Thierry Reding
2018-05-04 11:21     ` Dmitry Osipenko
2018-05-04 13:33 ` [PATCH v2 0/4] Restore ULPI USB on Tegra20 Marcel Ziswiler
2018-05-06 12:01   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 0/4] Restore ULPI USB on Tegra20' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).